Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set icon size #55

Merged
merged 1 commit into from
May 9, 2023
Merged

Set icon size #55

merged 1 commit into from
May 9, 2023

Conversation

maxime-carabina
Copy link
Contributor

We are adding a size for icons in the button component.

@maxime-carabina maxime-carabina linked an issue May 9, 2023 that may be closed by this pull request
fix icon button size #54
Closed
mazmassa
mazmassa reviewed May 9, 2023
View reviewed changes
src/components/Button/Button.stories.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
pivilartisant
pivilartisant approved these changes May 9, 2023
View reviewed changes
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
mazmassa
mazmassa approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@mazmassa mazmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Max! Thanks for that! 🎉

@maxime-carabina maxime-carabina merged commit ab311bf into main May 9, 2023
@maxime-carabina maxime-carabina deleted the fix-icon-button-size branch May 9, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivilartisant pivilartisant pivilartisant approved these changes

@mazmassa mazmassa mazmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix icon button size
3 participants
@maxime-carabina @pivilartisant @mazmassa