Dev Mastercoin clarifications #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although can you clarify what does "use the block timestamp for y" mean? |
|
It means when you calculate the Development Mastercoins at any moment (perhaps when a transactions from Exodus gets sent) you should use the last block found timestamp. Does that explain it? |
|
Yes. Grammar mistake - "When a transactions from Exodus" |
|
Makes sense to me. |
|
@ripper234 I've been glaring over the commits for 5 minutes but I can't seem to spot that sentence, where is it exactly? |
|
Ah sorry, it's just in the comments on this pull request, it's not on the commits themselves :) You can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quick notes on how and when to calculate the Exodus amount and make sure all implementations use the same calculations when dealing with years.