Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed for the issue (#24) #143

Merged
merged 8 commits into from
Feb 19, 2023
Merged

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness self-assigned this Feb 19, 2023
@myConsciousness myConsciousness linked an issue Feb 19, 2023 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added client service/media test v1 Indicates that it is a v1 endpoint. v2 Indicates that it is a v2 endpoint. labels Feb 19, 2023
@myConsciousness
Copy link
Member Author

Memo: Need to fix and add unit tests.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #143 (fe1fb34) into main (bd658cc) will increase coverage by 0.71%.
The diff coverage is 78.43%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   74.52%   75.24%   +0.71%     
==========================================
  Files         108      114       +6     
  Lines        1158     1248      +90     
==========================================
+ Hits          863      939      +76     
- Misses        295      309      +14     
Impacted Files Coverage Δ
lib/src/core/client/client.dart 100.00% <ø> (ø)
lib/src/core/client/client_context.dart 0.00% <0.00%> (ø)
lib/src/core/client/oauth2_client.dart 2.94% <0.00%> (-0.09%) ⬇️
lib/src/core/http_status.dart 100.00% <ø> (ø)
lib/src/service/entities/media_attachment.dart 100.00% <ø> (ø)
lib/src/core/exception/pending_exception.dart 6.25% <6.25%> (ø)
lib/src/core/service_helper.dart 83.33% <100.00%> (+8.62%) ⬆️
lib/src/service/base_service.dart 93.75% <100.00%> (+1.67%) ⬆️
lib/src/service/entities/media_focal_points.dart 100.00% <100.00%> (ø)
lib/src/service/entities/media_meta.dart 100.00% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myConsciousness
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 19, 2023

Build succeeded:

@bors bors bot merged commit a904ca7 into main Feb 19, 2023
@bors bors bot deleted the 24-feature-request-media-api-methods branch February 19, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client service/media test v1 Indicates that it is a v1 endpoint. v2 Indicates that it is a v2 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: media API methods
2 participants