Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide client scopes as a space delimited string instead of a json list #79

Merged
merged 2 commits into from
Dec 25, 2022

Conversation

Elleo
Copy link
Contributor

@Elleo Elleo commented Dec 24, 2022

1. Description

The currently existing behaviour sends scopes as a json encoded list (e.g. ["read", "write", "follow"]), however, Mastodon expects a space-separated string ("read write follow"). This PR corrects that behaviour so that apps are assigned the correct scopes by the Mastodon server.

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

Fixes #78

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! :)

@codecov-commenter
Copy link

Codecov Report

Merging #79 (8e80bff) into main (53eca1b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files          85       85           
  Lines         832      832           
=======================================
  Hits          577      577           
  Misses        255      255           
Impacted Files Coverage Δ
lib/src/service/v1/apps/apps_v1_service.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myConsciousness
Copy link
Member

@Elleo , Thanks for your contribution! :)

@myConsciousness
Copy link
Member

bors merge

@myConsciousness
Copy link
Member

@all-contributors please add @Elleo for code, bug, test

@allcontributors
Copy link
Contributor

@myConsciousness

I've put up a pull request to add @Elleo! 🎉

@bors
Copy link
Contributor

bors bot commented Dec 25, 2022

Build succeeded:

@bors bors bot merged commit 083a673 into mastodon-dart:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client creation sends invalid scope data
3 participants