-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better push notifications #4200
Comments
Please have clicking a notification open the status in the existing tab if there is one! Thanksssss~ |
Is it possible to make this usable from 3rd-party apps? |
Should be doable, the entire implementation is based on open standards. I guess they need to host the push service themselves (e.g. https://github.com/mozilla-services/autopush). |
@sorin-davidoi
|
Did not know that.
True, but that endpoint does not care who operates the push endpoint it receives - could be browser vendors or application developers.
True, that should be exposed via an API. |
Welcome notification
When the push subscription is registered, we currently send a welcome notification to verify that the endpoint is valid. I think this should allow the user to actually enable push notifications - makes them more likely to use the feature. We should probably also use the occasion to explain that they will work even if Mastodon is not open.
Integrate with the onboarding modal
Showcase the feature and allow the users to enable it - only if it is supported on the device.
Integrate with active session
Would show an icon next to the session if a push subscription is associated with the given session. Maybe even a button to send a test notification to that device.
Integrate with admin feature
When #1209 is implemented, maybe it would make sense to provide a checkbox to send push notifications to all users on the instance.
Payload too big
The specification requires push providers to accept a payload of at least 4 KB. This is not handled at all right now, pushing a bigger payload will silently fail. We should construct the payload, measure its size, and if it is too big we should trim the body of the notification.
Confusion regarding notification types
Users will be confused: what is the difference between desktop notifications and push notifications? If both are enabled, they will receive the notification twice (deduplicated by the OS since they have the same
tag
but still confusing). Best thing would be to have just one toggle in the UI and use push notifications when available and standard ones as fallback.Grouping
If you wake up and turn your WiFi on, you will be bombarded by all the notifications that you received over night.Not true, see comment. If you received more than a couple, it can be overwhelming - and annoying.I think that if you have more than a fixed number (four or five should do it) of notifications, they should be grouped:
N
new notifications'X
mentioned you \nY
favorited your status \nZ
boosted your status")The text was updated successfully, but these errors were encountered: