-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synchronization of remote featured tags #19380
Add synchronization of remote featured tags #19380
Conversation
Is it unavoidable to add a new |
I see, it would be better to put them together in a featured collection. |
9b22ce8
to
e3382f2
Compare
Changed featured_tags_collection_url so that it is used on a ad-hoc basis instead of being stored in the database. Add support for cases where the featured collection contains both Note and Hashtag. However, in versions prior to Mastodon v3.5.1, an exception occurs, so feature collections containing both notes and hashtags are not read correctly. For the time being, you should continue to use the featured tags collection. |
I am so sorry. I forgot I made |
This pull request will make the following changes
|
If CircleCI is enabled in the forked repository, I cannot check the results from the Checks tab of the Pull Request. We need to check the results in the CircleCI web UI of the forked repository. |
Okay, I see why. Thank you! |
* Add LIMIT of featured tag to instance API response * Add featured_tags_collection_url to Account * Add synchronization of remote featured tags * Deliver update activity when updating featured tag * Remove featured_tags_collection_url * Revert "Add featured_tags_collection_url to Account" This reverts commit cff349f. * Add hashtag sync from featured collections * Fix tag name normalize * Add target option to fetch featured collection * Refactor fetch_featured_tags_collection_service * Add LIMIT of featured tag to v1/instance API response
Regression from mastodon#19380
* Add LIMIT of featured tag to instance API response * Add featured_tags_collection_url to Account * Add synchronization of remote featured tags * Deliver update activity when updating featured tag * Remove featured_tags_collection_url * Revert "Add featured_tags_collection_url to Account" This reverts commit cff349f. * Add hashtag sync from featured collections * Fix tag name normalize * Add target option to fetch featured collection * Refactor fetch_featured_tags_collection_service * Add LIMIT of featured tag to v1/instance API response
Regression from mastodon#19380
Add function to sync remote account's featured tags.
Currently, the collection of featured tags is cached for 3 minutes, so if you deliver an Update activity immediately after an update, the update may fail. The load to deliver Update activity every time a featured tag is added or removed can be heavy. So, schedule it to be delivered in 3 minutes.
For updating, we can also introduce a method using the add/delete collection activity. What do you think?