Add variable autoFocus to video #22778
Conversation
|
Note that the |
There was a problem hiding this comment.
The issue occurs because embeds use detailed: true in app/views/statuses/_detailed_status.html.haml. It would make sense to me to decouple the autofocus from the detailed behavior. It would also make sense to use detailed in app/javascript/mastodon/features/status/components/detailed_status.js but that is another issue.
| @@ -617,7 +617,7 @@ class Video extends React.PureComponent { | |||
|
|
|||
| <div className='video-player__buttons-bar'> | |||
| <div className='video-player__buttons left'> | |||
| <button type='button' title={intl.formatMessage(paused ? messages.play : messages.pause)} aria-label={intl.formatMessage(paused ? messages.play : messages.pause)} className='player-button' onClick={this.togglePlay} autoFocus={detailed}><Icon id={paused ? 'play' : 'pause'} fixedWidth /></button> | |||
| <button type='button' title={intl.formatMessage(paused ? messages.play : messages.pause)} aria-label={intl.formatMessage(paused ? messages.play : messages.pause)} className='player-button' onClick={this.togglePlay}><Icon id={paused ? 'play' : 'pause'} fixedWidth /></button> | |||
There was a problem hiding this comment.
Instead of removing it altogether, I would add an autoFocus prop that app/javascript/mastodon/features/ui/components/video_modal.js would make use of in addition to detailed.
Akkiesoft
changed the title
* add variable autoFocus to video * set autoFocus in video_modal.js
* add variable autoFocus to video * set autoFocus in video_modal.js
Fixes #15281.