Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subsequent replies to unresolved status not being filtered from home #4190

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Fix subsequent replies to unresolved status not being filtered from home #4190

merged 1 commit into from
Jul 14, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jul 14, 2017

Resolves #4177 - smaller changeset

nightpool
nightpool requested changes Jul 14, 2017
View reviewed changes
Copy link
Member

@nightpool nightpool left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can you copy over the spec I wrote too? that code is very well spec'd and i'd hate to regress there

@akihikodaki akihikodaki added the bug Something isn't working label Jul 14, 2017
@Gargron Gargron force-pushed the fix-filter-subsequent-replies branch from 5481453 to 715e4af Compare July 14, 2017 13:11
nightpool
nightpool approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@nightpool nightpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gargron Gargron merged commit de397f3 into master Jul 14, 2017
@Gargron Gargron deleted the fix-filter-subsequent-replies branch July 14, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightpool nightpool nightpool approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gargron @nightpool @akihikodaki