Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust toot button style #4736

Closed
wants to merge 1 commit into from
Closed

Conversation

lynlynlynx
Copy link
Contributor

@lynlynlynx lynlynlynx commented Aug 29, 2017

I think this way is better than #4723 "fix toot button text be hidden when img pasted"

Pros

  • Solve ellipsis of toot buttons in some languages whose translation is long

  • Enlarge Formosan toot buttons

Before and after images below.

ba4

Cons

  • Padding becomes smaller in some languages
    I wonder if we prioritize usual(image is not attached) appearance or not πŸ€”
    Anyone has good way to solve this cons? Variable padding?
  • Can't solve ellipsis of all languages
    Bulgarian and Ukrainian image is attached.
    Spanish and Portuguese image is attached in private or direct toots.
    I think there is no way to solve this except increasing column width. πŸ€·β€β™‚οΈ
Before and after images below.

Padding becomes smaller in some languages
ba5
To put it the other way around.
ba8

Can't solve
ws000053
ws000054
ws000055


The appearance is almost same for languages use "TOOT" as "compose_form.publish".
ba7

Support Meiryo UI


Small fix button style


Small fix button style 2
@ykzts ykzts added the ui Front-end, design label Sep 2, 2017
Copy link
Member

@nightpool nightpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use flexbox to change the padding based on how much space is available?

At a minimum, we should never use !important styles unless something is very wrong with our selectors

@matyapiro31
Copy link

flexbox is not stable technology now, there are some difference among browsers remained, and also there is no reason why using padding isn't better than flexbox.
I agree with removing !import.

@nolanlawson
Copy link
Contributor

@matyapiro31 We don't support IE at all, and IE is the browser with the v1 version of flexbox. I think given we're essentially supporting latest Chrome/Edge/Firefox/Safari, it's safe to use flexbox. Furthermore, we already use flexbox in several places in the codebase. πŸ˜ƒ

@mattcoxonline
Copy link
Sponsor

mattcoxonline commented Nov 27, 2017

screen shot 2017-11-27 at 16 13 48

I started to tweak the padding and text size around the tootbox to see how things fit. And a small reduction in font size / icon sizes and maintaining an equal padding either side of the button seems to work quite well.

There's also the option for longer toot buttons to force the icon set to the left to collapse behind an elipses. This also forces you to take the decision on what is the primary action you want people to do; CW vs upload media vs other stuff. _See example labelled "Tootbox - Elipses"

However, we have a lot of space in the left column and I'm not sure why the grey strip of buttons does't run the full width of the input box? Maybe too crazy a suggestion. See example labeled "Tootbox - Full-width"

@lynlynlynx
Copy link
Contributor Author

Full-width textbox seems really nice to me.
I got stuck with this pull request, so I'll close it.
Would you create new request? @mattcoxonline

@lynlynlynx lynlynlynx mentioned this pull request Dec 7, 2017
@lynlynlynx lynlynlynx closed this Dec 7, 2017
@lynlynlynx lynlynlynx deleted the toot-button branch December 13, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants