Don't remove originals of boosted toots from timeline #5479
Conversation
|
Do people want to see duplicate original+reblog in their home? |
|
Some people toots after boost when they want to talk something related to the boosted toot. So, I want to see the same toot whenever some followee boosted. |
|
I find it annoying when the toot disappears after I boost it, yeah. I always have to remember to favorite it before boosting, and as @nullkal says you can't reply after boosting without finding the toot all over again. I think maybe in this one case duplicates can be tolerated. |
|
OTOH this PR appears to duplicate all reblogs, not just the one reblogged by the user themselves? |
|
I think that this PR is a good idea even if we're not dealing with toots the user boosted themselves. If I'm about to click the "favorite" button on a toot, and someone I'm following boosts that toot a second before I click, the toot will disappear from under my mouse and I'll click on some other random toot. If we don't want duplicates, then rather than removing the original we should just not show the boost. |
|
But yup, as @nullkal points out, not showing the boost would make "LB" posts more confusing, so I think it's fine to just have duplicates. |
|
Also, I believe that we still won't have duplicates in close proximity, because if a toot is already near the top of your timeline then boosts don't seem to get added to the timeline at all. |
|
Just checking in, are there any objections to this PR that haven't been addressed? |
|
I agree, current behavior is counter-intuitive and I would rather see duplicates or see the original post. |
Reblogs made in the same session do not have to be inserted anyway. |
* Don't remove originals of boosted toots from timeline * Remove unused argument to updateTimeline
I believe this fixes #5097 . I'd like to hear from @Gargron what the original rationale was for including this line, though.