Fix top level exception on unexpected event #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the PR works for me. > sysctl kern.osrelease kern.osrevision
kern.osrelease: 13.0-CURRENT
kern.osrevision: 199506 |
|
Fixes Jekyll live reload on my FreeBSD 13.0 (r365834)! |
|
I've submitted a PR on FreeBSD Bugzilla to include this patch in the port: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250432 Thanks again for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started hitting this issue on FreeBSD 12: guard/listen#475
I seem to be getting kqueue events with a filter of 0. It's not clear to me what the meaning of such an event is. Prior to this change I would see the behaviour in the linked issue. This patch causes these events to be ignored. I suspect this is just masking a bigger issue, but at least this makes the gem usable for me in the meantime.
I tested this by running a jekyll server on FreeBSD 12 with ruby 2.6.