-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interface: Added types property to the autocomplete predictions #42
interface: Added types property to the autocomplete predictions #42
Conversation
02b23f8
to
2a42ff8
Compare
flutter_google_places_sdk_platform_interface/lib/src/types/autocomplete_predictions.dart
Outdated
Show resolved
Hide resolved
2a42ff8
to
4e210e2
Compare
In a previous commit, some changes were made to the interface, (introduction of
open parameter is not nullable. The tests failed because the What do you think about this? How we can solve these issues? |
4e210e2
to
0d07dbe
Compare
@mrcsilverfox the tests needs to be a redone, but that's ok - you can ignore them for now. However the problem is that you're adding the Adding property to the implementations without the caller trying to parse it should not throw exceptions, so that should be the path forward; in each implementations (we have 4) verify we are returning the placeTypes, and after all 4 places are implemented and merged - we can change the response to include it and parse it. http: I think http is the only impl that might have it already actually, although it has a different name so might not work either. |
Ok, so can I modify all platform plugin implementation in the same PR? If you want to look all changes needed, this is my fork commit I had to comment some test, and refactor some classes. |
@mrcsilverfox Each package that gets published needs to have it's own commit - although we don't have to wait for any of them. Do note I'll check each one individually and will likely only be able to do it on the weekend. |
Ok, but how can I "test" if each package works if a need to reference to an interface that does not exist? |
@mrcsilverfox I belive I got confused, you're right. merged. |
No description provided.