Add .gitattributes; More ESLint checks

.eslintrc.json

@@ -9,16 +9,27 @@
     "chrome": true
   },
   "rules": {
+    "strict": ["error", "global"],
     "quotes": ["error", "single", { "avoidEscape": true }],
     "indent": ["error", "tab", { "SwitchCase": 1 }],
     "brace-style": "error",
     "curly": ["error", "multi-line"],
     "no-unexpected-multiline": "error",
     "semi": ["error", "never"],
     "no-unused-vars": "warn",
+    "no-unused-expressions": "error",
+    "no-use-before-define": ["error", { "functions": false }],
+    "no-bitwise": "error",
+    "wrap-iife": "error",
+    "new-cap": "error",
+    "no-undef": "error",
+    "no-caller": "error",
     "block-scoped-var": "error",
     "no-var": "error",
     "prefer-const": "error",
+    "eqeqeq": "error",
+    "no-eq-null": "error",
+    "no-labels": "error",
     "space-before-function-paren": ["error", "never"],
     "space-before-blocks": "error",
     "no-lone-blocks": "error",
@@ -30,6 +41,6 @@
     "space-unary-ops": "error",
     "spaced-comment": "error",
     "func-call-spacing": "error",
-    "no-console": "warn"
+    "no-console": "off"
   }
 }

.gitattributes

@@ -0,0 +1 @@
+* text=auto

README.md

@@ -134,6 +134,7 @@ Changes
 -   2.0.5 - 5th of December 2016
     * No user-facing changes.
     * Fix error in packaging (the new build system was not actually compressing the ZIP file, which different parts of the submission process for Chrome and Firefox didn't like—oops!)
+    * Add more code robustosity checks with ESLint.
 -   2.0.4 - 4th of December 2016
     * Clean up the appearance of the popup.
     * Increase 'momentary' highlight duration to two seconds, from one second.

scripts/build.js

@@ -59,11 +59,11 @@ function logStep(name) {
 function checkBuildMode() {
 	const args = process.argv.slice(2)
 
-	if (args.length !== 1 || buildModes.indexOf(args[0]) == -1) {
+	if (args.length !== 1 || buildModes.indexOf(args[0]) === -1) {
 		error(`Invalid build mode requested: expected one of [${buildModes}] but received '${args}'`)
 	}
 
-	if (args[0] == 'all') {
+	if (args[0] === 'all') {
 		return validBrowsers
 	}
 
@@ -121,10 +121,10 @@ function copyBackgroundScript(browser) {
 
 
 // Get PNG files from the cache (which will generate them if needed)
-function getPngs(browser) {
+function getPngs(cache, browser) {
 	logStep('Generating/copying in PNG files...')
 	browserPngSizes[browser].forEach((size) => {
-		const pngPath = pc.getPngPath(size)
+		const pngPath = cache.getPngPath(size)
 		const basename = path.basename(pngPath)
 		fse.copySync(pngPath, path.join(pathToBuild(browser), basename))
 	})
@@ -170,6 +170,6 @@ browsers.forEach((browser) => {
 	copyStaticFiles(browser)
 	mergeManifest(browser)
 	copyBackgroundScript(browser)
-	getPngs(browser)
+	getPngs(pc, browser)
 	makeZip(browser)
 })

scripts/lib/png-cache.js

@@ -6,6 +6,11 @@ const chalk = require('chalk')
 const svg2png = require('svg2png')
 
 module.exports = function(cacheDir, svgPath) {
+	// Initialisation
+	const svgModified = fse.statSync(svgPath).mtime
+	fse.ensureDirSync(cacheDir)
+
+
 	// Return the full path to the desired PNG
 	function pngPath(size) {
 		return path.join(cacheDir, 'landmarks-' + size + '.png')
@@ -33,10 +38,6 @@ module.exports = function(cacheDir, svgPath) {
 	}
 
 
-	// Initialisation
-	const svgModified = fse.statSync(svgPath).mtime
-	fse.ensureDirSync(cacheDir)
-
 	// Public API implementation
 	return {
 		// Get the path for a PNG of a particular size.

src/assemble/background.chrome.js

@@ -1,4 +1,4 @@
-
+/* eslint-disable strict */
 
 //
 // Install and Update

src/assemble/background.js

@@ -1,3 +1,5 @@
+'use strict'
+
 //
 // Keyboard Shortcut Handling
 //
@@ -49,7 +51,7 @@ function checkBrowserActionState(tabId, url) {
 }
 
 function startsWith(string, pattern) {
-	return string.substring(0, pattern.length) == pattern
+	return string.substring(0, pattern.length) === pattern
 }
 
 // If the page uses 'single-page app' techniques to load in new components --

src/static/content.js

@@ -21,6 +21,7 @@
    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
    THE SOFTWARE.
    */
+'use strict'
 
 let g_gotLandmarks = false        // Have we already found landmarks?
 let g_selectedIndex = -1          // Currently selected landmark

src/static/options.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const borderTypeId = 'border-type'
 
 function saveOptions() {

src/static/popup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // Handle incoming landmarks message response
 //
 // If there are landmarks, then the response will be a list of objects that