Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Resized" extension UI images aren't #11

Closed
matatk opened this issue Jun 1, 2016 · 0 comments
Closed

"Resized" extension UI images aren't #11

matatk opened this issue Jun 1, 2016 · 0 comments
Labels
bug upstream
Milestone
WebExtension MVP

Comments

@matatk
Copy link
Owner

matatk commented Jun 1, 2016 •
edited
Loading

In convert-to-webextension, an SVG file is converted to PNGs of various sizes for use in the Firefox (or other browsers') UI. The problem is that the images are not being resized; just clipped.

This apparent bug was reported to grunt-respimg.
@matatk matatk added the bug label Jun 1, 2016
@matatk matatk added the upstream label Jul 3, 2016
matatk added a commit that referenced this issue Jul 5, 2016
@matatk
SVG to PNG
6709212 
* Create a custom task to convert via ImageMagick; fixes #11
* Update deps accordingly
* Update manifest.json files accordingly
* Remove hacky 'todo' target for clean as it's redundant
@matatk matatk modified the milestone: WebExtension MVP Jul 11, 2016
@matatk matatk closed this as completed Aug 11, 2016
matatk added a commit that referenced this issue Dec 28, 2016
@matatk
Spec compliance; Robustness; Build
18fa3a4 
* Implement the concepts listed in #11 so that the code reads more like
  the spec.
* Add the <footer>-in-<blockquote> tests and ensure they pass (fixes
  #11)
* Was able to add some minor optimisations due to having the tests.
* Fix bug in build system whereby content.js had the wrong name.
@matatk matatk mentioned this issue Jan 3, 2017
Merged
@matatk matatk mentioned this issue Jul 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream
Projects
None yet
Milestone
WebExtension MVP
Development

No branches or pull requests
1 participant
@matatk