Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude hidden events #8

Open
wants to merge 1 commit into
base: skip_some_events
Choose a base branch
from

Conversation

AlanCoding
Copy link

Tested locally with the demo job template, and confirmed that the events produced reduces from 7 to 6, which removes the playbook_on_start event, as expected.

@matburt
Copy link
Owner

matburt commented Apr 13, 2020

Do you think this is something that a lot of folks would use? I'd say the number of non-stdout producing events might be pretty low.

@AlanCoding
Copy link
Author

I'd say the number of non-stdout producing events might be pretty low.

What evidence would it take for you to agree otherwise? In the demo playbook, there is 1 empty event, only because it targets no hosts. As the number of hosts / actual tasks increases, it limits to half of the events.

But that's not the reason for this - the reason for this is the problem you were trying to address. Run these scenarios:

ansible/ansible#68914

The point here is that the playbook is swamped by skipped events, which have ansible-runner associated events, but no output with these settings. Those events still get saved, and the ultimate reason that the user has no way out of the flood of events is because there is no way to turn off saving of these events.

That example still undersells the real motivation - which is a very large user who has decided that they only need the failed events reported. In that case, they want to silence the skipped, ok, and changed events, and they should reasonably expect congruence between how they do that with the ansible-playbook CLI and AWX. In these cases, there should be potentially millions of events with no output, and a handful of failed events.

matburt pushed a commit that referenced this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants