Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new action to fix build errors #158

Merged
merged 2 commits into from
Nov 25, 2020
Merged

use new action to fix build errors #158

merged 2 commits into from
Nov 25, 2020

Conversation

fdiblen
Copy link
Collaborator

@fdiblen fdiblen commented Nov 25, 2020 •
edited
Loading

Refs: #157
This PR fixes conda workflow issues.

@fdiblen fdiblen marked this pull request as ready for review November 25, 2020 10:59
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@florian-huber
Copy link
Collaborator

Nice, thanks a lot @fdiblen !

florian-huber
florian-huber approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@florian-huber florian-huber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and works well). Thanks Faruk!

@fdiblen fdiblen merged commit 144b492 into master Nov 25, 2020
@fdiblen fdiblen deleted the fix-conda-builds branch November 25, 2020 12:13
@fdiblen fdiblen mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-huber florian-huber florian-huber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdiblen @florian-huber