Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added require_precursor_mz_above_0 and tests #191

Merged
merged 13 commits into from
Mar 4, 2021
Merged

Added require_precursor_mz_above_0 and tests #191

merged 13 commits into from
Mar 4, 2021

Conversation

niekdejonge
Copy link
Collaborator

No description provided.

@niekdejonge niekdejonge mentioned this pull request Mar 3, 2021
Closed
Niek de Jonge added 2 commits March 3, 2021 18:14
florian-huber
florian-huber requested changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@florian-huber florian-huber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Niek!
Also very good extensive testing!

I added some small comments.
In addition, can you add the changes to CHANGELOG.md (let me know if that is unclear)?
Finally, also don't forget to add yourself to CITATION.cff and .zenodo.json ;)

@niekdejonge @florian-huber
Update matchms/filtering/require_precursor_mz.py
6d6d07f 
Co-authored-by: Florian Huber <36473328+florian-huber@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@niekdejonge niekdejonge merged commit abcaadb into master Mar 4, 2021
@niekdejonge niekdejonge deleted the add_require_precursor_mz branch March 4, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-huber florian-huber florian-huber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niekdejonge @florian-huber