Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reference score closest to the bin as backup for find_match_in_range #79

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

svenvanderburg
Copy link
Collaborator

@svenvanderburg svenvanderburg commented Mar 24, 2021

This actually seems like a much simpler solution. We just widen the range until we find a suitable pair.

Closes #72

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@florian-huber florian-huber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Sven! Looks much clearer now (and also makes more sense I assume).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select pair with closest similarity to bin center instead of highest similarity in data generation.
2 participants