Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search term on load may bomb mermaid chart #452

Closed
McShelby opened this issue Sep 13, 2020 · 1 comment
Closed

Search term on load may bomb mermaid chart #452

McShelby opened this issue Sep 13, 2020 · 1 comment

Comments

@McShelby
Copy link

Having a search term of "Alice" active on load of the page in the mermaid-exampleSite will "bomb" the mermaid chart.

This is because the mermaid chart and the execution of text highlightning are executed from different onLoad handlers.

Assuming that #410 will be merged before, this can be fixed by merging both onLoad handlers together.

One is contained in learn.js, the other in `hugo-learn.js'. I don't understand this separation anyway and it wasn't clear from the git history. Because of that, I would prefer both files into one.

@McShelby
Copy link
Author

McShelby commented Apr 4, 2023

Is fixed in the fork

@McShelby McShelby closed this as completed Apr 4, 2023
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
this code was unused
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant