solution #247
Open
solution #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogsevko
reviewed
May 26, 2020
src/getTime.js
Outdated
| @@ -18,7 +18,25 @@ | |||
| * @returns {string} - valid time | |||
| */ | |||
| function getTime(str) { | |||
| // write code here | |||
| const hhmm = str.match(/\b\d{2}:\d{2}\b/); | |||
There was a problem hiding this comment.
Твій regex метчить "неправильний" час, як то 24:50. Можна написати регулярний вираз так, щоб такі випадки не включались.
There was a problem hiding this comment.
Переускладнювати код регулярки не хочу, щоб зберегти читабельність.
There was a problem hiding this comment.
Suggested change
| const hhmm = str.match(/\b\d{2}:\d{2}\b/); | |
| const matches = str.match(/\b\d{2}:\d{2}\b/); |
ogsevko
approved these changes
May 26, 2020
danheim
suggested changes
May 27, 2020
src/getTime.js
Outdated
| @@ -18,7 +18,25 @@ | |||
| * @returns {string} - valid time | |||
| */ | |||
| function getTime(str) { | |||
| // write code here | |||
| const hhmm = str.match(/\b\d{2}:\d{2}\b/); | |||
There was a problem hiding this comment.
Suggested change
| const hhmm = str.match(/\b\d{2}:\d{2}\b/); | |
| const matches = str.match(/\b\d{2}:\d{2}\b/); |
src/getTime.js
Outdated
Comment on lines
23
to
39
| if (!hhmm) { | ||
| return ''; | ||
| } | ||
|
|
||
| const hh = hhmm[0].substr(0, 2); | ||
| const mm = hhmm[0].substr(3, 2); | ||
| let time = ''; | ||
|
|
||
| if (+hh > 23) { | ||
| time = ''; | ||
| } else if (+mm > 59) { | ||
| time = ''; | ||
| } else { | ||
| time = hh + ':' + mm; | ||
| } | ||
|
|
||
| return time; |
There was a problem hiding this comment.
этого не должно быть, мы работаем с регулярными выражениями
danheim
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.