makeRobot #2516
Open
makeRobot #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Aug 22, 2023
src/makeRobot.js
Outdated
Comment on lines
42
to
46
| goRight: goRight, | ||
| goLeft: goLeft, | ||
| goForward: goForward, | ||
| goBack: goBack, | ||
| evacuate: evacuate, |
There was a problem hiding this comment.
Redundant
Suggested change
| goRight: goRight, | |
| goLeft: goLeft, | |
| goForward: goForward, | |
| goBack: goBack, | |
| evacuate: evacuate, |
src/makeRobot.js
Outdated
Comment on lines
52
to
55
| coords: { | ||
| 'x': 0, | ||
| 'y': 0, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| coords: { | |
| 'x': 0, | |
| 'y': 0, | |
| }, | |
| coords: { | |
| x: 0, | |
| y: 0, | |
| }, |
src/makeRobot.js
Outdated
Comment on lines
68
to
73
| if (step < 0) { | ||
| return robot; | ||
| } | ||
| robot.coords['x'] += step; | ||
|
|
||
| return robot; |
There was a problem hiding this comment.
You can rewrite like this everywhere
Suggested change
| if (step < 0) { | |
| return robot; | |
| } | |
| robot.coords['x'] += step; | |
| return robot; | |
| if (step > 0) { | |
| this.coords.x += step; | |
| } | |
| return this; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.