Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caja-notebook: Add notebook scroll event #1422

Merged
merged 1 commit into from
Jul 16, 2020
Merged

caja-notebook: Add notebook scroll event #1422

merged 1 commit into from
Jul 16, 2020

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Jun 29, 2020

@rbuj rbuj requested a review from a team June 29, 2020 22:56
raveit65
raveit65 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
does what it promises.

@raveit65 raveit65 mentioned this pull request Jul 14, 2020
Merged
lukefromdc
lukefromdc approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine, scrolling on tabs to switch tabs works with this and not on master. Looks good to go

@lukefromdc lukefromdc merged commit 9f2c966 into master Jul 16, 2020
@lukefromdc lukefromdc deleted the caja_notebook_scroll_event branch July 16, 2020 05:14
@lukefromdc lukefromdc mentioned this pull request Oct 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukefromdc lukefromdc lukefromdc approved these changes

@raveit65 raveit65 raveit65 approved these changes

@clefebvre clefebvre Awaiting requested review from clefebvre

@cwendling cwendling Awaiting requested review from cwendling

@flexiondotorg flexiondotorg Awaiting requested review from flexiondotorg

@monsta monsta Awaiting requested review from monsta

@sc0w sc0w Awaiting requested review from sc0w

@vkareh vkareh Awaiting requested review from vkareh

@yetist yetist Awaiting requested review from yetist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuj @raveit65 @lukefromdc