Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comparison of integer expressions of different signedness: ‘size_t’ #288

Merged
merged 1 commit into from
Sep 4, 2019
Merged

comparison of integer expressions of different signedness: ‘size_t’ #288

merged 1 commit into from
Sep 4, 2019

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Aug 27, 2019

No description provided.

@raveit65 raveit65 mentioned this pull request Aug 27, 2019
Merged
@raveit65
Copy link
Member

raveit65 commented Aug 27, 2019 •
edited
Loading

Just rebased to fix hopefully ubuntu build at travis.

@raveit65 raveit65 requested a review from a team August 27, 2019 20:42
raveit65
raveit65 approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@raveit65 raveit65 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build warnings if compiled with -Wsign-compare and engrampa runs fine since several days.

@raveit65 raveit65 requested a review from a team August 31, 2019 15:24
lukefromdc
lukefromdc approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine, both as-is and after being rebased against today's master. Looks good to go

@lukefromdc lukefromdc requested a review from a team September 3, 2019 02:07
@sc0w sc0w merged commit e741517 into master Sep 4, 2019
@sc0w sc0w deleted the size_t branch September 4, 2019 23:54
This was referenced Jul 12, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raveit65 raveit65 raveit65 approved these changes

@sc0w sc0w sc0w approved these changes

@lukefromdc lukefromdc lukefromdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbuj @raveit65 @sc0w @lukefromdc