Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fr-window: duplicated code #360

Merged
merged 1 commit into from
Mar 10, 2020
Merged

fr-window: duplicated code #360

merged 1 commit into from
Mar 10, 2020

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Jan 31, 2020

No description provided.

@raveit65 raveit65 requested a review from a team February 1, 2020 11:31
@raveit65
Copy link
Member

raveit65 commented Feb 4, 2020

Which icon is affected in engrampa window?

@rbuj
Copy link
Contributor Author

rbuj commented Feb 4, 2020

The icons shown in the file list (mime types).

raveit65
raveit65 approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine.

lukefromdc
lukefromdc approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine, no problems with icons. Emblems added to a file did not work, but didn't work with master either so that is not caused by this PR

@lukefromdc lukefromdc merged commit 21f37c3 into master Mar 10, 2020
@lukefromdc lukefromdc deleted the duplicated-code branch March 10, 2020 05:24
@shlyakpavel shlyakpavel mentioned this pull request Jul 12, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raveit65 raveit65 raveit65 approved these changes

@lukefromdc lukefromdc lukefromdc approved these changes

@clefebvre clefebvre Awaiting requested review from clefebvre

@cwendling cwendling Awaiting requested review from cwendling

@dnk dnk Awaiting requested review from dnk

@flexiondotorg flexiondotorg Awaiting requested review from flexiondotorg

@monsta monsta Awaiting requested review from monsta

@sc0w sc0w Awaiting requested review from sc0w

@selectiveduplicate selectiveduplicate Awaiting requested review from selectiveduplicate

@sunweaver sunweaver Awaiting requested review from sunweaver

@vkareh vkareh Awaiting requested review from vkareh

@yetist yetist Awaiting requested review from yetist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuj @raveit65 @lukefromdc