Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from intltools to gettext #149

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Migrate from intltools to gettext #149

merged 2 commits into from
Nov 9, 2019

Conversation

yetist
Copy link
Member

@yetist yetist commented Oct 29, 2019

No description provided.

@yetist yetist requested a review from a team October 29, 2019 06:54
Copy link
Member

@vkareh vkareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine for me

@vkareh vkareh requested a review from a team October 29, 2019 12:35
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine, though I don't know a lot about this transition

@lukefromdc lukefromdc requested a review from a team October 29, 2019 18:04
@raveit65
Copy link
Member

raveit65 commented Nov 7, 2019

@yetist
We need translator hints for desktop files. Can you please add them?

@yetist
Copy link
Member Author

yetist commented Nov 9, 2019

@yetist
We need translator hints for desktop files. Can you please add them?

ok, done.

Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
./autogen.sh && ./makepot
diff -uprN mate-media-master.pot mate-media.pot > diff-pot-files.patch
shows me that all translations are there, and all desktop files have translator hints.
Installation/uninstallation to /usr/local/share/locale/*/LC_MESSAGES/*.mo works fine.
All necessary files are in a tarball generated by distcheck.
Thanks.

@raveit65 raveit65 merged commit 02ec93b into master Nov 9, 2019
@raveit65 raveit65 deleted the gettext branch November 9, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants