Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid deprecated 'g_type_class_add_private' #150

Merged
merged 12 commits into from
Oct 29, 2019
Merged

avoid deprecated 'g_type_class_add_private' #150

merged 12 commits into from
Oct 29, 2019

Conversation

sc0w
Copy link
Member

@sc0w sc0w commented Oct 29, 2019

No description provided.

@sc0w sc0w requested a review from a team October 29, 2019 09:42
vkareh
vkareh approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@vkareh vkareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me, thanks!

@vkareh vkareh requested a review from a team October 29, 2019 12:13
lukefromdc
lukefromdc approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The panel applet, status icon and volume control all look fine with this. A spot check of the commits shows the usual G_DEFINE_TYPE_WITH_PRIVATE/gvc_speaker_test_get_instance_private transition that has worked well so many times before

@lukefromdc lukefromdc merged commit 5ee13d9 into master Oct 29, 2019
@sc0w sc0w deleted the g_type_class_add_private branch October 29, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkareh vkareh vkareh approved these changes

@lukefromdc lukefromdc lukefromdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc0w @vkareh @lukefromdc