Switch to meson build system #338
Conversation
|
Nice idea, but please do not remove autotools project. Edit: and there is a conflict with master branch |
raveit65
requested review from
raveit65,
clefebvre,
cwendling,
flexiondotorg,
monsta,
rbuj,
sc0w,
selectiveduplicate,
sunweaver,
vkareh,
yetist and
a team
|
Thanks, can you try to rebase your branch to master, please? |
|
It seems the |
applets/inhibit/inhibit-applet.c
Outdated
| @@ -21,9 +21,7 @@ | |||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | |||
| */ | |||
|
|
|||
| #ifdef HAVE_CONFIG_H | |||
There was a problem hiding this comment.
Is it necessary to modify the header file?
There was a problem hiding this comment.
I think use the follow will be better, This will not modify the header file and source files.
add_project_arguments([
'-DHAVE_CONFIG_H',
], language: 'c')
data/meson.build
Outdated
| 'mate-power-statistics.1', | ||
| 'mate-power-preferences.1' | ||
| ], | ||
| install_dir: mandir_path |
meson_options.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| option('enable-deprecated', type: 'boolean', value: false, description: 'Warn about deprecated usages') | |||
There was a problem hiding this comment.
See https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting, please use deprecated to replace enable-deprecated.
|
@vaurelios |
|
Not all directories will be uninstalled. Ignore glib dir, it's only |
|
Any news? |
|
Anybody in there? |
fix indentation in some files
a left over from gnome is the action and status icons was installed to $(pkgdatadir). now all icons are installed to $(datadir).
|
Sorry, i forgot to test this :/ @yetist |
Here everything work as expected. The |
@vaurelios |
|
@rbuj |
|
@raveit65 This works fine on my machine with I have |
|
There is a linking issue when /usr/share/local/help/ isn't empty after testing installation with Checking permissions: All images are linked to Honestly, i don't really understand why people love meson with so much possible problems. Any way, issue isn't related to PR. |
|
@vaurelios Can you please take a look at it? |
|
When using autotools for installation we have |
|
|
@vaurelios |
|
The languages argument is deprecated in the gnome module v0.43.0. If we omit this obsolescence, languages can be passed as an argument for building the help, so the list of available languages can be generated automatically. |
|
I found that both the brightness and inhibit applets won't load with Meson builds, probably installed to the wrong place based on this error I got with testing the libsecret PR's meson build in which means mate-power-backlight-helper also went to the wrong place. This too has been reported by others against master when built with Meson |
|
I agree we should revert this, merge the libsecret work, rebase this on the resulting master, and fix the problems. Otherwise other work is hung up behind fixing this |
|
I found more missing files compared to my unpacked fedora RPM package. Meson installation: Applets can't start because of wrong files. Meson installation: Icons are normally under /usr/share/mate-power-manager/ installed. Meson installation: |
|
@vaurelios |
|
please revert! after libsecret merge i will took time to fix all these issues. |
|
Ok, commits are reverted from master. |
|
Port to libsecret is merged. |
|
I'm working on it again! Comparing the install directory tree of both build system I noticed two things in Autotools build:
So my question is: this is the right behavior or there's a problem with Autotools build? |
|
In my installations Well, i don't know exactly why we use 2 separate dirs, maybe to avoid conflicts, but this is definitely the correct behavior. |
|
What is the status of this? Is it still being worked on? |
|
@vaurelios Can continue updating? I need this feature and can review the code. Thank you |
There are several advantages in using meson build system. here are some