Better shellcheck support #139
Conversation
Supports --enable=all for optional checks Adds shellcheck directives to properly source files
There was a problem hiding this comment.
Thank you very much for your PR - you clearly put a lot of effort in it, and I really appreciate that you have addressed typos and refreshed the code style as well. I am in favor of this change, shellcheck compliance is a meaningful and valuable goal.
It will take me some time to make a thorough review, so I went through some of those changes and pointed things out that caught my eye. Thank you again for your time and for contributing back.
Please add your name to the AUTHORS file, and to the Changelog as a new feature.
Co-authored-by: Matěj Týč <matej.tyc@gmail.com>
Fixed comments to pull request Cleaned up warning during make install Added files to gitignore
|
Cleaned up most of the comments, also fixed a warning during make install: Added to the make file missing examples |
|
We are mostly good, I have left some remarks, then I will check out complex parts of the PR again, but I don't expect that much more issues will show up. |
Co-authored-by: Matěj Týč <matej.tyc@gmail.com>
|
Looks good, the only issue that remains is the generation of this example. |
Argbash documentation changes
|
I apologize for taking so long to get back to this. I fixed up the patch file and generated the docs successfully. I think that's the last item. |
|
Fixed up the docker workflow, I think that's everything |
Supports --enable=all for shellcheck https://github.com/koalaman/shellcheck/blob/master/shellcheck.1.md#options
Adds shellcheck directives to properly source files
The major change was cleaning up every variable instance to be compliant with https://github.com/koalaman/shellcheck/wiki/SC2250
Thank you for having a good test suite. It caught a lot of the corner cases I missed initially.
Basically the main problem I was having is I run at a stricter level of linting than this project. So I brought it in line with the stricter set of rules. It shouldn't have any affect on people using a looser rule set.