-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using another argv parser #77
Comments
Yeah, our custom commander usage is only because they took over a year to
get to merging my or. And when they did, they asked to refactor all
dependencies into local code... Which wasn't a thing when I started!
…On Tue, Dec 11, 2018 at 8:58 AM Alec Larson ***@***.***> wrote:
cacjs/cac <https://github.com/cacjs/cac> is a drop-in replacement for
commander made by @egoist <https://github.com/egoist>.
What I dislike about *commander*:
- tons of unresolved issues and PRs
- its creator is no longer involved
What I like about *cac*:
- it uses semantic-release
- it uses Typescript
What gives me pause about *cac*:
- it has 46% test coverage (not very good)
- it's not as "mature"
- it doesn't have as many users (yet?)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#77>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAh3Xz-cWsO0pufPkRJP1KYoRhb7KRdQks5u38f-gaJpZM4ZNlJ5>
.
|
I chose it so that I could to git style subcommands. But it could be that
there are benefits to a monolithic command... Like the ability to do
inspection of a single process.
…On Tue, Dec 11, 2018 at 8:59 AM Matt Walters ***@***.***> wrote:
Yeah, our custom commander usage is only because they took over a year to
get to merging my or. And when they did, they asked to refactor all
dependencies into local code... Which wasn't a thing when I started!
On Tue, Dec 11, 2018 at 8:58 AM Alec Larson ***@***.***>
wrote:
> cacjs/cac <https://github.com/cacjs/cac> is a drop-in replacement for
> commander made by @egoist <https://github.com/egoist>.
>
> What I dislike about *commander*:
>
> - tons of unresolved issues and PRs
> - its creator is no longer involved
>
> What I like about *cac*:
>
> - it uses semantic-release
> - it uses Typescript
>
> What gives me pause about *cac*:
>
> - it has 46% test coverage (not very good)
> - it's not as "mature"
> - it doesn't have as many users (yet?)
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#77>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAh3Xz-cWsO0pufPkRJP1KYoRhb7KRdQks5u38f-gaJpZM4ZNlJ5>
> .
>
|
What did your PR add to commander?
I think I'll open an issue about this. |
Also, since you're using email. Note that I edited the OP to add "fixes #39" |
Search for mateodelnorte. You'll see it. IIRC, it fixed git style
subcommands on Windows.
…On Tue, Dec 11, 2018 at 9:03 AM Alec Larson ***@***.***> wrote:
What did your PR add to commander?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAh3X6YKscfWF7w1NrPchaI45JWu5GHSks5u38kegaJpZM4ZNlJ5>
.
|
Not seeing any commits authored by you: https://github.com/tj/commander.js/search?q=author%3Amateodelnorte&unscoped_q=author%3Amateodelnorte&type=Commits |
I'll just look at your fork: https://github.com/mateodelnorte/commander.js 😛 |
It's still unmerged...
tj/commander.js#604
…On Tue, Dec 11, 2018 at 9:06 AM Alec Larson ***@***.***> wrote:
Not seeing any commits authored by you:
https://github.com/tj/commander.js/search?q=author%3Amateodelnorte&unscoped_q=author%3Amateodelnorte&type=Commits
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAh3X3llzGNJuAytZyqKLM22cvN4_ZDBks5u38nvgaJpZM4ZNlJ5>
.
|
Ah yes. The biggest aspect is that it allows dependencies to add git sub
commands.
…On Tue, Dec 11, 2018 at 9:08 AM Matt Walters ***@***.***> wrote:
It's still unmerged...
tj/commander.js#604
On Tue, Dec 11, 2018 at 9:06 AM Alec Larson ***@***.***>
wrote:
> Not seeing any commits authored by you:
> https://github.com/tj/commander.js/search?q=author%3Amateodelnorte&unscoped_q=author%3Amateodelnorte&type=Commits
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> <#77 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAh3X3llzGNJuAytZyqKLM22cvN4_ZDBks5u38nvgaJpZM4ZNlJ5>
> .
>
|
Of course it's not merged yet. :) Good news! CAC already supports "git-like subcommands". It says so in the README! 🎉 |
Actually, I might have jumped the shark.. |
We'll just have to see if it supports them being applied by other modules.
If not, we can make a PR over there.
…On Tue, Dec 11, 2018 at 9:11 AM Alec Larson ***@***.***> wrote:
Of course it's not merged yet. :)
Good news! CAC already supports "git-like subcommands". It says so in the
README! 🎉
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAh3X2li_YCrsg4dBXisr-wu2rWl3W9yks5u38srgaJpZM4ZNlJ5>
.
|
with git-like subcommands you are considering also git flow or not? ( i.e git flow feature start featurename) at the moment (if i understand correctly how the argument parsing is done ) the only way to support it at the moment is adding git flow support to meta-git plugin (but in my opinion should be a dedicated and optional plugin) |
You could easily add a plugin that just adds |
this is kind of a tangent so I won't go deep into it, but I gave up git flow years ago. Git Flow multiplied by 10-20+ projects (microservices, modules, libs) is way too much mental overhead. Trunk based development with robust CD is much more preferable, imo. I know everyone has their own styles and meta should support any workflow you'd like, but I really do not miss git flow haha. |
Different situation required different development flow ( at least should)
i'm non a fan of git flow but is working at the moment but a generic
multi-repo coordination tool should support more options as possible.
My concern were related to match the git [command] respect to git flow
[command] to select the plug-in
Il giorno Mer 2 Gen 2019, 20:44 Patrick Scott <notifications@github.com> ha
scritto:
… @Jcbobo <https://github.com/Jcbobo>
with git-like subcommands you are considering also git flow or not?
this is kind of a tangent so I won't go deep into it, but I gave up git
flow years ago. Git Flow multiplied by 10-20+ projects (microservices,
modules, libs) is way too much mental overhead. Trunk based development
with robust CD is much more preferable, imo. I know everyone has their own
styles and meta should support any workflow you'd like, but I really do not
miss git flow haha.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJUfZ_CJSjxNR9xJy5PEqlFDM1BmS2a0ks5u_Qw3gaJpZM4ZNlJ5>
.
|
Yes, like I said - it should support any workflow. So your concern is how a
Because
Would be picked up by |
about how plugins with "similar" command are disambiguate |
as supposed creating a plugin with name git flow, and command
is exacly what i noticed trying to implement the git flow plugin |
My guess is that you didn't have the package linked correctly. If that were
true, I would think that meta-git's own child commands (like
meta-git-status) wouldn't work.
Matt
…On Mon, Jan 7, 2019 at 10:41 AM Andrea Boetto ***@***.***> wrote:
as supposed creating a plugin with name git flow, and command
Yes, like I said - it should support any workflow.
So your concern is how a git flow plugin should work given that they are
piggy backing on git as well
git flow init -d
git flow feature start <your feature>
Because
meta git flow
Would be picked up by meta-git ?
is exacly what i noticed trying to implement the git flow plugin
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAh3X1aThG9Lduyzudq16qpa7Hja8cW1ks5vA3jRgaJpZM4ZNlJ5>
.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump. I still think this would be a good move forward. |
I've been using another commander-like parser recently called "sade". I haven't had time to compare it with "cac", but it's almost half the size. |
This looks very commander-like. I don't see coverage for git-style subcommands, though. And that's really the main feature we get from commander, other than ability to specify commands and options. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
cacjs/cac is a drop-in replacement for commander made by @egoist.
What I dislike about commander:
What I like about cac:
semantic-release
What gives me pause about cac:
The text was updated successfully, but these errors were encountered: