Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using another argv parser #77

Closed
aleclarson opened this issue Dec 11, 2018 · 25 comments
Closed

consider using another argv parser #77

aleclarson opened this issue Dec 11, 2018 · 25 comments
Labels

Comments

@aleclarson
Copy link
Contributor

aleclarson commented Dec 11, 2018

cacjs/cac is a drop-in replacement for commander made by @egoist.

What I dislike about commander:

  • tons of unresolved issues and PRs
  • its creator is no longer involved

What I like about cac:

What gives me pause about cac:

  • it has 46% test coverage (not very good)
  • it's not as "mature"
  • it doesn't have as many users (yet?)
@mateodelnorte
Copy link
Owner

mateodelnorte commented Dec 11, 2018 via email

@mateodelnorte
Copy link
Owner

mateodelnorte commented Dec 11, 2018 via email

@aleclarson
Copy link
Contributor Author

aleclarson commented Dec 11, 2018

What did your PR add to commander?

git style subcommands

I think I'll open an issue about this.

@aleclarson
Copy link
Contributor Author

Also, since you're using email. Note that I edited the OP to add "fixes #39"

@mateodelnorte
Copy link
Owner

mateodelnorte commented Dec 11, 2018 via email

@aleclarson
Copy link
Contributor Author

@aleclarson
Copy link
Contributor Author

I'll just look at your fork: https://github.com/mateodelnorte/commander.js 😛

@mateodelnorte
Copy link
Owner

mateodelnorte commented Dec 11, 2018 via email

@mateodelnorte
Copy link
Owner

mateodelnorte commented Dec 11, 2018 via email

@aleclarson
Copy link
Contributor Author

Of course it's not merged yet. :)

Good news! CAC already supports "git-like subcommands". It says so in the README! 🎉

@aleclarson
Copy link
Contributor Author

Actually, I might have jumped the shark..

@mateodelnorte
Copy link
Owner

mateodelnorte commented Dec 11, 2018 via email

@Jcbobo
Copy link

Jcbobo commented Jan 2, 2019

with git-like subcommands you are considering also git flow or not? ( i.e git flow feature start featurename) at the moment (if i understand correctly how the argument parsing is done ) the only way to support it at the moment is adding git flow support to meta-git plugin (but in my opinion should be a dedicated and optional plugin)

@mateodelnorte
Copy link
Owner

You could easily add a plugin that just adds meta-git-flow-X commands. It wouldn't need to be in meta-git.

@patrickleet
Copy link
Collaborator

@Jcbobo

with git-like subcommands you are considering also git flow or not?

this is kind of a tangent so I won't go deep into it, but I gave up git flow years ago. Git Flow multiplied by 10-20+ projects (microservices, modules, libs) is way too much mental overhead. Trunk based development with robust CD is much more preferable, imo. I know everyone has their own styles and meta should support any workflow you'd like, but I really do not miss git flow haha.

@Jcbobo
Copy link

Jcbobo commented Jan 2, 2019 via email

@patrickleet
Copy link
Collaborator

Yes, like I said - it should support any workflow.

So your concern is how a git flow plugin should work given that they are piggy backing on git as well

git flow init -d
git flow feature start <your feature>

Because

meta git flow

Would be picked up by meta-git ?

@Jcbobo
Copy link

Jcbobo commented Jan 2, 2019

about how plugins with "similar" command are disambiguate

@Jcbobo
Copy link

Jcbobo commented Jan 7, 2019

as supposed creating a plugin with name git flow, and command

Yes, like I said - it should support any workflow.

So your concern is how a git flow plugin should work given that they are piggy backing on git as well

git flow init -d
git flow feature start <your feature>

Because

meta git flow

Would be picked up by meta-git ?

is exacly what i noticed trying to implement the git flow plugin

@mateodelnorte
Copy link
Owner

mateodelnorte commented Jan 7, 2019 via email

@stale
Copy link

stale bot commented Jun 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 13, 2019
@aleclarson
Copy link
Contributor Author

Bump. I still think this would be a good move forward.

@stale stale bot removed the wontfix label Jun 13, 2019
@aleclarson
Copy link
Contributor Author

I've been using another commander-like parser recently called "sade". I haven't had time to compare it with "cac", but it's almost half the size.

@mateodelnorte
Copy link
Owner

This looks very commander-like. I don't see coverage for git-style subcommands, though. And that's really the main feature we get from commander, other than ability to specify commands and options.

@stale
Copy link

stale bot commented Sep 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 1, 2019
@stale stale bot closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants