-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error: failed android/provider/Settings$Secure.smali' in framework.jar cannot be remedied #134
Comments
There is a log file generated by the program (what you poster is the output, I know, a little confusing). Could you post a log to paste in, perhaps? We just updated the patches yesterday, and sometimes these breakages that you are reporting are a manner of us setting the patch date wrong. If I can track down your build (do you have a link?) I can maybe figure it out. Thanks for them report. |
Thanks for the reply! Here is the content of the log: 1 out of 9 hunks FAILED -- saving rejects to file 'smali/android/provider/Settings$Secure.smali.rej' ... apply preloaded.patch ... !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!! error: failed android/provider/Settings$Secure.smali' in framework.jar cannot be remedied !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! I couldn't find the rejects file mentioned. Does it put it someplace specific? The build that I am using is: Thanks again! |
I am getting this same issue attempting to patch cm 10.1 (and pa 3.6) with openpdroid. The end of my log file is as follows: ... apply framework.patch ... ... apply preloaded.patch ... !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!! error: failed android/provider/Settings$Secure.smali' in framework.jar cannot be remedied !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! If you would like the full log let me know. |
Yeah, I need the full log (paste in or equivalent please). All I know from them posted error is that something isn't working correctly in your setup, thenuodater perhaps. The settings.secure error was fixed by updating our patches a week or more ago. |
Here it is, appreciate your help: ROOT= /media/hayden/Hayden/Downloads/auto_patcher checking for updatesUpdater: Auto-Patcher is already up to date verify tools/usr/bin/patch verify ROMrunning ./auto_patcher cm-10.1.0.2-d2vzw.zip openpdroidPATH= /media/hayden/Hayden/Downloads/auto_patcher/tmp20130703111110:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games unzip patch toolsunzip patch patchesprobe rom typeStandard Build QueryVER= v2.9.91OS= linux-gnu 64bitVID= 4.2.2PID= openpdroidMID= cm_d2vzw-userdebugRID= cmANDR= 4.2BDID= 20130701DID= d2vzwBID= 20130626Patches are openpdroid/4.2/cm/20130626 Current HEAD: 4c1fa52 Switch to SlimRom aapt+apktool for Linux/Cygwin. (h/t Caldair for idea+testing) DELETE FILES=COPY FILES= system/media/PDroid.jpegJAR FILES= system/framework/framework.jar system/framework/core.jar system/framework/services.jar system/framework/telephony-common.jarAPK FILES= system/app/Mms.apkIMG FILES=TXT FILES=unzip romcreate updater script... using Clockworkmod installer ... generated updater-scriptui_print(""); create restore.zipdecompile system files... decompile framework.jar ... ... extract preloaded-classes ... ... decompile core.jar ... ... decompile services.jar ... ... decompile telephony-common.jar ... ... installing framework files ... ... decompile Mms.apk ... copy patch openpdroid/4.2/cm/20130626... copying system/media/PDroid.jpeg ... ... overwriting system/media/PDroid.jpeg from openpdroid ... ... overwriting ContentResolver.smali ... delete patch openpdroid/4.2/cm/20130626jar patch openpdroid/4.2/cm/20130626... apply framework.patch ... ... apply preloaded.patch ... !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!! error: failed android/provider/Settings$Secure.smali' in framework.jar cannot be remedied !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
Sorry for the delay, it is a holiday where I live. I did not recognize this CM-10.1.0.2 so I looked it up. That looks like it is a RC build. RC builds can be tricky for us, because while they have current build dates in the build.prop, they are actually using older code. There are two solutions, either download the latest nightly (from get.cm, the ones with a date in the zip name) and use the autopatcher as normal. Or, you can specify the earlier patches (the patches we had made for the code the RC is made from) on the command line. normally you run the autopatcher like this
to specify a date, you use (note the
You can see the patches we have available by entering Good luck, let us know how it goes. |
According to http://get.cm/?device=d2vzw 10.1.0.2 was a stable release, however it is not the most recent stable release like I thought. I'll give those solutions a try and get back to you. Thank you very much for the help, and for your work on this awesome project! |
It seems to be working for me now as of the latest updates as of today. Thanks! |
Worked perfect, thank you! |
Same issue with cm10.1.2 |
No...the 10.1.whatever builds are RC candidates or Final builds or whatever. They use old code in new builds and therefore do not work with the build query we wrote that matches your ROM to a ROMTYPE and patch date. The easiest thing is to just use then latest cm10.1 nightly release. You can also manually patch this rom if you wish. From experience with this issue you need to run
|
I got a update.zip from cyanogen updater, after i installed 10.1.0. The updater offered 10.1.1 and 10.1.2 i chose the 10.1.2. Before flashing, i tried to patch it with auto-patcher: ./auto_patcher ROM.zip openpdroid cm10 Shouldn't this be the way to build a openpdroid.zip for a cyanogen 10.x.y ROM? As an user i do not know which date the versions in the zip are (but i know the release date of the zip, which is from july), but i would expect the auto-patcher to be able to detect it, if there is already a patch matching the files in the update.zip. |
we probably cross-posted. Look at the answer right above your post. The Final builds use old code. I could maybe throw a hack in the acript I am thinking about it, lots and lots of problems from users, generally |
I'm still not sure, what this means, and what to do. So from the perspective of getting a working version ... the patcher should not try to detect the releasedate and such stuff, but detect which class is in the zip, and which patch matches it, or not? |
Well, thanks for the vote of confidence. The auto-patcher is deigned to work with releases that use the latest code available. Period. That generally means nightly releases, which are maybe 99% of the released zips. There is no guesswork there. When our patches break due to upstream changes we make new patches. The auto-patcher was originally written so that you chose a romtype (cm, aokp, whatever) and the also designated apatch date that matched the release. I wrote a query that checks your build date and takes care of much of that work for you. The problem you are hhaving is that the CM team has released build that do not use their latest changes. Those builds reflect their Stable or Final tags. Those builds have current build dates, which reflect the actual date the server built them, but uses a hodge-podge of commits that changes as to CM's level of assurance as to which commits constitute stable. So yes, the code in CM10.1 night lies is ahead of 10.1.2 because the .2 is incrementing only the designation Final, not the 10.1. Bottom line, the auto-patcher is designed to work with night lies, which is 99% of the use case. You may patch the Final builds, but it involves bypassing the convienance of the build query and designated the dates. Use the line I gave you the first time. |
okay, it seems to work with that line. Is there any file, at where the last-commit date in the release tag is the same as needed for the auto-patcher? Or are there even stable releases, which cannot be patched at all, because different files needing a patch are at different versions? |
On 07/13/2013 12:09 PM, allo- wrote:
I am not sure what you are asking, though. There is a conceivable There is the theoretical scenario where they could add a bugfix that But if you are worried about bad matches or incorrectly applied patches, |
okay, i understood one of your previous posts as if there were many nightlies merged together in a stable release. Then there could be a set of files, which do not work with a single nightly-patch. I patched the new 10.1.2 with my old openpdroid.zip and it seems to have worked. Is this okay, or will i get any not so obvious problems and should reflash cm10.1.2 and the update.zip generated with your cmdline? Thanks for your work, anyway :) |
Same issue patching last couple of cm10.1 nightlies for Asus tf300t - http://get.cm/?device=tf300t (e.g. cm-10.1-20130713-NIGHTLY-tf300t.zip). Have tried all versions of openpdroid patches in patches/openpdroid/4.2/cm
|
Hmmm...this looks the same but is different. Your log shows that the autopatcher is up to date but is, for some reason, using the old patches. Would you try entering ./batch.sh and then patch again? It should have happened as you updated, but perhaps something interrupted that. @AJStein is working on a tighter integration, but it is still in the works. Later tonight I will try downloading this and see what is up. You should be able to manually select the newer patches as well
But the build query function should be doing that for you. |
Yeah, I just downloaded the latest from the get.cm and it patches for me. If batch.sh doesn't work, post another log. The easiest thing to do in that situation might just be to delete it and git clone again. Or download from the download page, it will auto-update for you upon first run. If trouble persists after that, let us know. But it looks to be something unique to your set-up |
Re-running batch.sh fixed it. Thanks. |
glad to hear it! |
Just saw the same error (but maybe not the same cause) trying to patch this build: http://forum.xda-developers.com/showthread.php?t=2164461 It's a CM-based build for the HTC Doubleshot (MyTouch 4G Slide), I've always had success patching these builds with auto_patcher before. The log ends: ... apply framework.patch ... ... apply preloaded.patch ... !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!! error: failed android/provider/Settings$Secure.smali' in framework.jar cannot be remedied !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! and says earlier: "Patches are openpdroid/4.2/cm/20130719" |
I am gonna need a link to the whole log to really give you sound advice. The rom_probe (the mechanism we match which rom and patch date is best) has been a little difficult because lots of Final and Milestone builds are popping up and use old code on recent build dates....it doesn't matter. Pastebin a log and hopefully I can give you some advice. |
Thanks, no problem: http://paste.fedoraproject.org/28494/06352113 |
I just saw you posted this. I will look at it today, ok? |
Sorry back after a long hiatus out. FYI the log posted above is dead for me; Fedora Paste says it is not there anymore. |
siiiigh. I thought we had the default expiry on longer. try http://paste.fedoraproject.org/29064/20627513 |
I looked for a download with that name but did not see any CM-10.1 builds for double shot. But regardless, I would only have done these commands here: The odds are pretty good that one of those will work, but if not, then it would just be one of the rare cases where we wouldn't be able to support an unofficial build due to divation from uptream sources. But that is unlikely. Check the other patches or a brand new nightly. Good luck! @AJStein Glad you're back! We are getting ready for next version... |
mateor: the build I'm using is unofficial, I gave a link to the XDA thread a few comments back. Earlier snapshots of the same build have patched fine previously. The command I ran was "auto_patcher cm-10.1-20130727-UNOFFICIAL-doubleshot.zip openpdroid cm" - so you're suggesting explicitly specifying a couple of older patch versions to see if that works? |
I didn't see the link, but yes. The current official builds are patching, |
20130516 gave a successful patch. Thanks! |
I get this when trying to patch cm-10.1.0 for the galaxy note (1) on either at&t or T-mobile. I run the following command line:
./auto_patcher ~/Downloads/att/cm-10.1.0-quincyatt.zip tabletUI,openpdroid cm
Thanks for the great work!!
Here is a full run-log:
./auto_patcher ~/Downloads/att/cm-10.1.0-quincyatt.zip tabletUI,openpdroid cm
The Auto-Patcher v2.9.881
verify tools
verify ROM
unzip patch tools
unzip patch patches
inflated: system/build.prop
... result of ROM check: RIL= SamsungQualcommUiccRIL
probe rom type
... result of ROM check: version= 4.2.2 rom= cm ...
... Using cm patches ...
... tabletUI patch date has been set to: 20130403 ...
unzip rom
inflated: system/app/Mms.apk
inflated: system/app/SystemUI.apk
inflated: system/framework/android.policy.jar
inflated: system/framework/core.jar
inflated: system/framework/framework-res.apk
inflated: system/framework/framework.jar
inflated: system/framework/services.jar
inflated: system/framework/telephony-common.jar
create updater script
inflated: META-INF/com/google/android/update-binary
inflated: META-INF/com/google/android/updater-script
... using Clockworkmod installer ...
create restore.zip
decompile system files
... decompile android.policy.jar ...
... decompile services.jar ...
... decompile framework.jar ...
... extract preloaded-classes ...
... decompile core.jar ...
... decompile telephony-common.jar ...
... installing framework files ...
I: Framework installed to: /home/dsteen/apktool/framework/1.apk
... decompile framework-res.apk ...
... decompile SystemUI.apk ...
... decompile Mms.apk ...
jar patch tabletUI/4.2/cm/20130403
... apply android.policy.patch ...
... apply services.patch ...
apk patch tabletUI/4.2/cm/20130403
... apply framework-res.apk.patch ...
... apply SystemUI.apk.patch ...
copy patch openpdroid/4.2/cm/latest
... copying system/media/PDroid.jpeg ...
... overwriting system/media/PDroid.jpeg from openpdroid ...
... overwriting ContentResolver.smali ...
jar patch openpdroid/4.2/cm/latest
... apply framework.patch ...
... apply preloaded.patch ...
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!! error: failed android/provider/Settings$Secure.smali' in framework.jar cannot be remedied
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Use ./auto_patcher -h for the help menu
The text was updated successfully, but these errors were encountered: