Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update package.json for all typescript components #576

Merged
merged 52 commits into from
Dec 28, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Dec 28, 2018

fixes #568 and #569

redo of PR https://github.com/material-components/material-components-web-react/pull/573...rebased 0.8.0 with master and caused conflicts.

Matt Goo and others added 30 commits December 28, 2018 09:45
BREAKING CHANGE: withRipple is no longer the default export.
@moog16 moog16 changed the base branch from master to rc0.8.0 December 28, 2018 20:00
@googlebot

This comment has been minimized.

@googlebot
Copy link

CLAs look good, thanks!

@moog16 moog16 changed the base branch from rc0.8.0 to master December 28, 2018 20:47
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@codecov-io
Copy link

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          61       61           
  Lines        2560     2560           
  Branches      371      371           
=======================================
  Hits         2419     2419           
  Misses         50       50           
  Partials       91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f971a8...2a6d1e1. Read the comment docs.

@moog16 moog16 merged commit 7f38952 into master Dec 28, 2018
@moog16 moog16 deleted the fix/typescriptpackagejson branch December 28, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants