Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit a646516

Browse files
authored
fix(checkbox): Remove RTL styles from checkbox ripple (#5134)
1 parent 199534d commit a646516

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

packages/mdc-checkbox/_mixins.scss

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
@import "@material/feature-targeting/functions";
2626
@import "@material/feature-targeting/mixins";
2727
@import "@material/ripple/mixins";
28-
@import "@material/rtl/mixins";
2928
@import "@material/touch-target/mixins";
3029
@import "./functions";
3130
@import "./keyframes";
@@ -61,7 +60,7 @@ $mdc-checkbox-ripple-target: ".mdc-checkbox__ripple";
6160
}
6261

6362
@include mdc-checkbox-focus-indicator-color($mdc-checkbox-baseline-theme-color, $query: $query);
64-
@include mdc-checkbox-density($mdc-checkbox-density-default-scale, $query: $query);
63+
@include mdc-checkbox-density($mdc-checkbox-density-scale, $query: $query);
6564
}
6665

6766
@include mdc-checkbox-container-colors($query: $query);
@@ -217,7 +216,7 @@ $mdc-checkbox-ripple-target: ".mdc-checkbox__ripple";
217216
/// Sets density scale for checkbox.
218217
///
219218
/// @param {Number | String} $density-scale - Density scale value for component. Supported density scale values
220-
/// `-3`, `-2`, `-1`, `0`.
219+
/// `-4`, `-3`, `-2`, `-1`, `0`.
221220
///
222221
@mixin mdc-checkbox-density($density-scale, $query: mdc-feature-all()) {
223222
$size: mdc-density-prop-value(
@@ -239,9 +238,8 @@ $mdc-checkbox-ripple-target: ".mdc-checkbox__ripple";
239238

240239
.mdc-checkbox__background {
241240
@include mdc-feature-targets($feat-structure) {
242-
@include mdc-rtl-reflexive-position(left, $checkbox-padding, ".mdc-checkbox");
243-
244241
top: $checkbox-padding;
242+
left: $checkbox-padding;
245243
}
246244
}
247245

packages/mdc-checkbox/_variables.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ $mdc-checkbox-focus-indicator-opacity: map-get($mdc-ripple-dark-ink-opacities, f
3939

4040
$mdc-checkbox-minimum-size: 28px !default;
4141
$mdc-checkbox-maximum-size: $mdc-checkbox-ripple-size !default;
42-
$mdc-checkbox-density-default-scale: $mdc-density-default-scale !default;
42+
$mdc-checkbox-density-scale: $mdc-density-default-scale !default;
4343
$mdc-checkbox-density-config: (
4444
size: (
4545
minimum: $mdc-checkbox-minimum-size,

packages/mdc-checkbox/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"@material/dom": "^3.1.0",
2525
"@material/feature-targeting": "^3.1.0",
2626
"@material/ripple": "^3.2.0",
27-
"@material/rtl": "^3.2.0",
2827
"@material/theme": "^3.1.0",
2928
"@material/touch-target": "^0.0.0",
3029
"tslib": "^1.9.3"

0 commit comments

Comments
 (0)