Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit bd84694

Browse files
authored
fix(text-field): Update label position and shake animation (#2594)
1 parent 4c52589 commit bd84694

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

packages/mdc-textfield/_mixins.scss

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,10 @@
176176

177177
margin-top: 12px;
178178
margin-bottom: 4px;
179-
font-size: .813rem;
179+
180+
.mdc-floating-label {
181+
font-size: .813rem;
182+
}
180183
}
181184

182185
@mixin mdc-required-text-field-label-asterisk_() {
@@ -231,7 +234,7 @@
231234
}
232235

233236
.mdc-floating-label {
234-
bottom: 18px;
237+
bottom: 16px;
235238
}
236239

237240
.mdc-text-field__icon {
@@ -382,11 +385,19 @@
382385
@mixin mdc-text-field-outlined-with-leading-icon_ {
383386
@include mdc-floating-label-float-position($mdc-text-field-outlined-label-position-y, $mdc-text-field-outlined-with-leading-icon-label-position-x);
384387
@include mdc-floating-label-shake-animation(text-field-outlined-leading-icon);
388+
389+
@include mdc-rtl {
390+
@include mdc-floating-label-shake-animation(text-field-outlined-leading-icon-rtl);
391+
}
385392
}
386393

387394
@mixin mdc-text-field-outlined-dense-with-leading-icon_ {
388395
@include mdc-floating-label-float-position($mdc-text-field-outlined-dense-label-position-y, $mdc-text-field-outlined-dense-with-leading-icon-label-position-x, $mdc-text-field-dense-label-scale);
389396
@include mdc-floating-label-shake-animation(text-field-outlined-leading-icon-dense);
397+
398+
@include mdc-rtl {
399+
@include mdc-floating-label-shake-animation(text-field-outlined-leading-icon-dense-rtl);
400+
}
390401
}
391402

392403
@mixin mdc-text-field-with-trailing-icon_ {

packages/mdc-textfield/_variables.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ $mdc-textarea-disabled-background: rgba(249, 249, 249, 1);
4040
$mdc-text-field-border-radius: 4px !default;
4141

4242
$mdc-text-field-box-label-position-y: 50%;
43-
$mdc-text-field-box-dense-label-position-y: 90%;
43+
$mdc-text-field-box-dense-label-position-y: 70%;
4444
$mdc-text-field-dense-label-scale: .923;
4545
$mdc-text-field-outlined-label-position-y: 130%;
46-
$mdc-text-field-outlined-dense-label-position-y: 145%;
46+
$mdc-text-field-outlined-dense-label-position-y: 110%;
4747
$mdc-text-field-outlined-with-leading-icon-label-position-x: 32px;
4848
$mdc-text-field-outlined-dense-with-leading-icon-label-position-x: 21px;
4949
$mdc-text-field-textarea-label-position-y: 50%;

packages/mdc-textfield/mdc-text-field.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,4 +246,6 @@
246246
@include mdc-floating-label-shake-keyframes(text-field-outlined-dense, $mdc-text-field-outlined-dense-label-position-y, 0%, $mdc-text-field-dense-label-scale);
247247
@include mdc-floating-label-shake-keyframes(text-field-outlined-leading-icon, $mdc-text-field-outlined-label-position-y, $mdc-text-field-outlined-with-leading-icon-label-position-x);
248248
@include mdc-floating-label-shake-keyframes(text-field-outlined-leading-icon-dense, $mdc-text-field-outlined-dense-label-position-y, $mdc-text-field-outlined-dense-with-leading-icon-label-position-x, $mdc-text-field-dense-label-scale);
249+
@include mdc-floating-label-shake-keyframes(text-field-outlined-leading-icon-rtl, $mdc-text-field-outlined-label-position-y, -$mdc-text-field-outlined-with-leading-icon-label-position-x);
250+
@include mdc-floating-label-shake-keyframes(text-field-outlined-leading-icon-dense-rtl, $mdc-text-field-outlined-dense-label-position-y, -$mdc-text-field-outlined-dense-with-leading-icon-label-position-x, $mdc-text-field-dense-label-scale);
249251
@include mdc-floating-label-shake-keyframes(textarea, $mdc-text-field-textarea-label-position-y, 0%, $mdc-text-field-textarea-label-scale);

0 commit comments

Comments
 (0)