fix(top-app-bar): Remove applyPassive function from toolbar/top app b…

…ar (#2487) The basic `scroll` event cannot be canceled, so `{passive: true}` has no effect.
material-components · Mar 30, 2018 · c252aba · c252aba
1 parent 3f23821
commit c252aba
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 122 deletions.
diff --git a/packages/mdc-toolbar/index.js b/packages/mdc-toolbar/index.js
@@ -18,10 +18,8 @@ import {MDCComponent} from '@material/base/index';
 import {MDCRipple} from '@material/ripple/index';
 
 import MDCToolbarFoundation from './foundation';
-import * as util from './util';
 
 export {MDCToolbarFoundation};
-export {util};
 
 export class MDCToolbar extends MDCComponent {
   static attachTo(root) {
@@ -66,8 +64,8 @@ export class MDCToolbar extends MDCComponent {
       hasClass: (className) => this.root_.classList.contains(className),
       addClass: (className) => this.root_.classList.add(className),
       removeClass: (className) => this.root_.classList.remove(className),
-      registerScrollHandler: (handler) => window.addEventListener('scroll', handler, util.applyPassive()),
-      deregisterScrollHandler: (handler) => window.removeEventListener('scroll', handler, util.applyPassive()),
+      registerScrollHandler: (handler) => window.addEventListener('scroll', handler),
+      deregisterScrollHandler: (handler) => window.removeEventListener('scroll', handler),
       registerResizeHandler: (handler) => window.addEventListener('resize', handler),
       deregisterResizeHandler: (handler) => window.removeEventListener('resize', handler),
       getViewportWidth: () => window.innerWidth,

diff --git a/packages/mdc-toolbar/util.js b/packages/mdc-toolbar/util.js
diff --git a/packages/mdc-top-app-bar/index.js b/packages/mdc-top-app-bar/index.js
@@ -20,7 +20,6 @@ import MDCTopAppBarFoundation from './foundation';
 import MDCComponent from '@material/base/component';
 import {MDCRipple} from '@material/ripple/index';
 import {cssClasses, strings} from './constants';
-import * as util from './util';
 import MDCShortTopAppBarFoundation from './short/foundation';
 
 /**
@@ -89,7 +88,7 @@ class MDCTopAppBar extends MDCComponent {
       notifyNavigationIconClicked: () => {
         this.emit(strings.NAVIGATION_EVENT, {});
       },
-      registerScrollHandler: (handler) => window.addEventListener('scroll', handler, util.applyPassive()),
+      registerScrollHandler: (handler) => window.addEventListener('scroll', handler),
       deregisterScrollHandler: (handler) => window.removeEventListener('scroll', handler),
       getViewportScrollY: () => window.pageYOffset,
       getTotalActionItems: () =>
@@ -108,4 +107,4 @@ class MDCTopAppBar extends MDCComponent {
   }
 }
 
-export {MDCTopAppBar, MDCTopAppBarFoundation, MDCShortTopAppBarFoundation, util};
+export {MDCTopAppBar, MDCTopAppBarFoundation, MDCShortTopAppBarFoundation};
diff --git a/packages/mdc-top-app-bar/util.js b/packages/mdc-top-app-bar/util.js
diff --git a/test/unit/mdc-top-app-bar/util.test.js b/test/unit/mdc-top-app-bar/util.test.js