Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit f71025f

Browse files
authored
fix(theme): replace inline comments in property-values map with multiline comments (#1746)
Due to an unfortunate bug in `scss-parser`, the inline comments in the property-values map were being prepended to the following lines in the build process to transform for Bazel, effectively commenting out any line that appeared directly after an inline comment in the map. While that bug is still present, replacing the inline comments with multiline comments reduces the impact of the bug.
1 parent 1d9cd68 commit f71025f

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

packages/mdc-theme/_variables.scss

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,65 +75,65 @@ $mdc-theme-text-colors: (
7575
//
7676

7777
$mdc-theme-property-values: (
78-
// Primary
78+
/* Primary */
7979
primary: $mdc-theme-primary,
8080
primary-light: $mdc-theme-primary-light,
8181
primary-dark: $mdc-theme-primary-dark,
82-
// Secondary
82+
/* Secondary */
8383
secondary: $mdc-theme-secondary,
8484
secondary-light: $mdc-theme-secondary-light,
8585
secondary-dark: $mdc-theme-secondary-dark,
86-
// Background
86+
/* Background */
8787
background: $mdc-theme-background,
88-
// Text-primary on "primary" background
88+
/* Text-primary on "primary" background */
8989
text-primary-on-primary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-tone), primary),
9090
text-secondary-on-primary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-tone), secondary),
9191
text-hint-on-primary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-tone), hint),
9292
text-disabled-on-primary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-tone), disabled),
9393
text-icon-on-primary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-tone), icon),
94-
// Text-primary on "primary-light" background
94+
/* Text-primary on "primary-light" background */
9595
text-primary-on-primary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-light-tone), primary),
9696
text-secondary-on-primary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-light-tone), secondary),
9797
text-hint-on-primary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-light-tone), hint),
9898
text-disabled-on-primary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-light-tone), disabled),
9999
text-icon-on-primary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-light-tone), icon),
100-
// Text-primary on "primary-dark" background
100+
/* Text-primary on "primary-dark" background */
101101
text-primary-on-primary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-dark-tone), primary),
102102
text-secondary-on-primary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-dark-tone), secondary),
103103
text-hint-on-primary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-dark-tone), hint),
104104
text-disabled-on-primary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-dark-tone), disabled),
105105
text-icon-on-primary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-primary-dark-tone), icon),
106-
// Text-primary on "secondary" background
106+
/* Text-primary on "secondary" background */
107107
text-primary-on-secondary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-tone), primary),
108108
text-secondary-on-secondary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-tone), secondary),
109109
text-hint-on-secondary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-tone), hint),
110110
text-disabled-on-secondary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-tone), disabled),
111111
text-icon-on-secondary: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-tone), icon),
112-
// Text-primary on "secondary-light" background
112+
/* Text-primary on "secondary-light" background */
113113
text-primary-on-secondary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-light-tone), primary),
114114
text-secondary-on-secondary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-light-tone), secondary),
115115
text-hint-on-secondary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-light-tone), hint),
116116
text-disabled-on-secondary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-light-tone), disabled),
117117
text-icon-on-secondary-light: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-light-tone), icon),
118-
// Text-primary on "secondary-dark" background
118+
/* Text-primary on "secondary-dark" background */
119119
text-primary-on-secondary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-dark-tone), primary),
120120
text-secondary-on-secondary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-dark-tone), secondary),
121121
text-hint-on-secondary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-dark-tone), hint),
122122
text-disabled-on-secondary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-dark-tone), disabled),
123123
text-icon-on-secondary-dark: map-get(map-get($mdc-theme-text-colors, $mdc-theme-secondary-dark-tone), icon),
124-
// Text-primary on "background" background
124+
/* Text-primary on "background" background */
125125
text-primary-on-background: map-get(map-get($mdc-theme-text-colors, $mdc-theme-background-tone), primary),
126126
text-secondary-on-background: map-get(map-get($mdc-theme-text-colors, $mdc-theme-background-tone), secondary),
127127
text-hint-on-background: map-get(map-get($mdc-theme-text-colors, $mdc-theme-background-tone), hint),
128128
text-disabled-on-background: map-get(map-get($mdc-theme-text-colors, $mdc-theme-background-tone), disabled),
129129
text-icon-on-background: map-get(map-get($mdc-theme-text-colors, $mdc-theme-background-tone), icon),
130-
// Text-primary on "light" background
130+
/* Text-primary on "light" background */
131131
text-primary-on-light: map-get(map-get($mdc-theme-text-colors, dark), primary),
132132
text-secondary-on-light: map-get(map-get($mdc-theme-text-colors, dark), secondary),
133133
text-hint-on-light: map-get(map-get($mdc-theme-text-colors, dark), hint),
134134
text-disabled-on-light: map-get(map-get($mdc-theme-text-colors, dark), disabled),
135135
text-icon-on-light: map-get(map-get($mdc-theme-text-colors, dark), icon),
136-
// Text-primary on "dark" background
136+
/* Text-primary on "dark" background */
137137
text-primary-on-dark: map-get(map-get($mdc-theme-text-colors, light), primary),
138138
text-secondary-on-dark: map-get(map-get($mdc-theme-text-colors, light), secondary),
139139
text-hint-on-dark: map-get(map-get($mdc-theme-text-colors, light), hint),

0 commit comments

Comments
 (0)