Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdc-select menu positioning logic incorrect when select appears near viewport edge #671

Closed
marcusmoqvist opened this issue May 18, 2017 · 1 comment
Closed

mdc-select menu positioning logic incorrect when select appears near viewport edge #671

marcusmoqvist opened this issue May 18, 2017 · 1 comment
Labels
backlog bug

Comments

@marcusmoqvist
Copy link

What MDC-Web Version are you using?

0.11.1 via this page:
https://material-components-web.appspot.com/

What browser(s) is this bug affecting?

Chrome version 58.0.3029.110 (64-bit)
Edge 38.14393.1066.0

What OS are you using?

Win 10

What are the steps to reproduce the bug?

  1. Go to https://material-components-web.appspot.com/select.html
  2. Reduce screen height so that the bottom of the browser is just below the first select menu
  3. Select "Milk, Yogurt, and Cheese"
  4. Press the select menu again, the last 2 options are now missing

What is the expected behavior?

All options should be visible

What is the actual behavior?

The last 2 options are missing

selectmenubugg
@traviskaufman
Copy link
Contributor

Definitely a bug. Thank you for filing.

@traviskaufman traviskaufman changed the title Select menu not showing all options mdc-select menu positioning loci incorrect when select appears near viewport edge May 18, 2017
@traviskaufman traviskaufman changed the title mdc-select menu positioning loci incorrect when select appears near viewport edge mdc-select menu positioning logic incorrect when select appears near viewport edge May 18, 2017
@tranrate tranrate mentioned this issue May 18, 2017
Merged
bwobrien pushed a commit that referenced this issue Jul 26, 2017
@tranrate @bwobrien
fix(select): menu positioning logic incorrect when select appears nea…
874f043 
…r viewport edge #671 (#680)

* Update foundation.js

Correct logic when Select Menu overflows at Bottom of screen, simplify code, and remove redundant object. Resolves LukeBergen's comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@traviskaufman @marcusmoqvist