Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3 Typography #348

Merged
merged 22 commits into from
May 17, 2022
Merged

M3 Typography #348

merged 22 commits into from
May 17, 2022

Conversation

PatelUtkarsh
Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh commented Apr 26, 2022

Summary

Fixes #314 #348

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@coveralls
Copy link

coveralls commented Apr 27, 2022

Pull Request Test Coverage Report for Build 2232173165

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 121 of 140 (86.43%) changed or added relevant lines in 9 files are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.9%) to 80.199%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugin/php/class-admin.php 0 1 0.0%
plugin/assets/src/customizer/customize-controls.js 0 2 0.0%
plugin/assets/src/customizer/components/google-fonts-control/index.js 0 3 0.0%
plugin/php/customizer/class-controls.php 92 105 87.62%
Files with Coverage Reduction New Missed Lines %
plugin/php/customizer/class-controls.php 4 93.29%
plugin/php/class-plugin.php 6 93.55%
plugin/assets/src/customizer/components/google-fonts-control/index.js 7 41.51%
Totals Coverage Status
Change from base Build 2227790934: 0.9%
Covered Lines: 4755
Relevant Lines: 5791

💛 - Coveralls

@PatelUtkarsh PatelUtkarsh marked this pull request as ready for review April 29, 2022 06:25
@emeaguiar emeaguiar merged commit 0364485 into develop May 17, 2022
@emeaguiar emeaguiar deleted the m3/typography branch May 17, 2022 15:07
PatelUtkarsh added a commit that referenced this pull request May 26, 2022
PatelUtkarsh added a commit that referenced this pull request May 26, 2022
emeaguiar added a commit that referenced this pull request Jun 14, 2022
Revert "Merge pull request #348 from material-components/m3/typography"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[M3] Typography Tokens simplification
3 participants