Remove local definition of mapIndexed and forEachIndexed in example #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebraminio
commented
Aug 18, 2023
| @@ -6,7 +6,7 @@ description: Demonstrates how to use the dynamic_color package. | |||
| publish_to: "none" # Remove this line if you wish to publish to pub.dev | |||
|
|
|||
| environment: | |||
| sdk: ">=2.17.0-0 <4.0.0" | |||
| sdk: ">=3.0.0 <4.0.0" | |||
There was a problem hiding this comment.
I had to do this in order to have access to record destructing syntax.
guidezpl
approved these changes
Sep 4, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The story about this change starts in dart-archive/collection#305 that I wanted to add indexed variant of none/every/any but instead learnt about
.indexedand the fact it's possibly (and maybe not) going to be deprecated.thingsIndexedin favor of.indexed.dart-archive/collection#305 (comment) so I went ahead removing.thingsIndexedfrom my codebase and in the process even found a compiler bug! dart-lang/sdk#53268While searching for
.thingsIndexedin my codebase and using.indexed.instead (which was a good thing as I could use list comprehension much better), I've learnt the only place IntelliJ's IDE's search engine is finding instances of.mapIndexedand.forEachIndexedis in examples of dynamic color library which my app uses, interestingly I had two contributions to the library also when it wasn't merged to this package. Now I wonder while you aren't even usingcollections'smapIndexedandforEachIndexed, is it possible to remove the uses in the dynamic color's example and just use the more recommended way so my IntelliJ's search result of my project can reach to zero.Thanks!