Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix total_doc synth population #322

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Fix total_doc synth population #322

merged 2 commits into from
Jul 6, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 6, 2021

This PR fixes the bug mentioned in issue #309 with total_doc population when filters are included in addition to keywords.

@munrojm munrojm added the release:patch Patch release label Jul 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #322 (ba2cd81) into main (0bbefea) will increase coverage by 56.70%.
The diff coverage is 79.32%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #322       +/-   ##
===========================================
+ Coverage   32.39%   89.09%   +56.70%     
===========================================
  Files         109       59       -50     
  Lines        3084     1917     -1167     
===========================================
+ Hits          999     1708      +709     
+ Misses       2085      209     -1876     
Impacted Files Coverage Δ
src/mp_api/__init__.py 100.00% <ø> (+43.47%) ⬆️
src/mp_api/routes/synthesis/data_adaptor.py 0.00% <0.00%> (ø)
src/mp_api/routes/synthesis/data_adaptor_synpro.py 0.00% <0.00%> (ø)
src/mp_api/routes/tasks/client.py 92.85% <ø> (+28.15%) ⬆️
src/mp_api/routes/dielectric/client.py 91.66% <50.00%> (+46.66%) ⬆️
src/mp_api/routes/molecules/client.py 90.32% <50.00%> (+51.03%) ⬆️
src/mp_api/routes/elasticity/client.py 93.93% <66.66%> (+59.45%) ⬆️
src/mp_api/routes/electrodes/client.py 87.50% <66.66%> (+37.50%) ⬆️
src/mp_api/routes/piezo/client.py 89.47% <66.66%> (+33.91%) ⬆️
src/mp_api/routes/robocrys/client.py 92.30% <66.66%> (+19.58%) ⬆️
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1366950...ba2cd81. Read the comment docs.

@munrojm munrojm merged commit a31b032 into main Jul 6, 2021
@munrojm munrojm deleted the synthesis_and_xas_bugs branch July 6, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants