Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task_id to material_id in xas tests #366

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Task_id to material_id in xas tests #366

merged 1 commit into from
Aug 20, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Aug 20, 2021

This fixes xas tests to accommodate change in query operators from task_id to material_id.

@munrojm munrojm added the release:minor Minor release bump label Aug 20, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #366 (60bd03a) into main (903f78c) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   93.12%   93.08%   -0.05%     
==========================================
  Files          61       61              
  Lines        1965     1966       +1     
==========================================
  Hits         1830     1830              
- Misses        135      136       +1     
Impacted Files Coverage Δ
src/mp_api/__init__.py 90.00% <75.00%> (-10.00%) ⬇️
src/mp_api/routes/xas/query_operators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d5c1c...60bd03a. Read the comment docs.

@munrojm munrojm merged commit b37c334 into main Aug 20, 2021
@mkhorton
Copy link
Member

Thanks @munrojm, apologies I missed this

@munrojm
Copy link
Member Author

munrojm commented Aug 20, 2021

@mkhorton, no worries!

@munrojm munrojm deleted the xas_test_fix branch August 20, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants