Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core rester method change #406

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Core rester method change #406

merged 1 commit into from
Oct 15, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 15, 2021

get_document_by_id changed to to get_data_by_id for all clients.

@munrojm munrojm added the release:patch Patch release label Oct 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #406 (7bcf6d4) into main (b07ff60) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   92.43%   92.68%   +0.24%     
==========================================
  Files          61       61              
  Lines        2010     2010              
==========================================
+ Hits         1858     1863       +5     
+ Misses        152      147       -5     
Impacted Files Coverage Δ
src/mp_api/client.py 96.64% <100.00%> (+1.34%) ⬆️
src/mp_api/core/client.py 91.41% <100.00%> (ø)
src/mp_api/routes/charge_density/client.py 100.00% <100.00%> (+10.00%) ⬆️
src/mp_api/routes/electronic_structure/client.py 87.85% <100.00%> (ø)
src/mp_api/routes/materials/client.py 86.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07ff60...7bcf6d4. Read the comment docs.

@munrojm munrojm merged commit 4917f31 into main Oct 15, 2021
@munrojm munrojm deleted the get_method_update branch October 15, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants