Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reference solids to construct the ion reference phase diagram #533

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

mkhorton
Copy link
Member

Addresses issue described here: https://matsci.org/t/issue-querying-pourbaix-entries-using-the-mp-api-rester/40651/6

And also closes bug report action item for Fe-C Pourbaix diagram on web app.

@mkhorton mkhorton added release:minor Minor release bump release:patch Patch release and removed release:minor Minor release bump labels Feb 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #533 (df60edf) into main (7ce7c4c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          34       34           
  Lines        1309     1309           
=======================================
  Hits         1212     1212           
  Misses         97       97           
Impacted Files Coverage Δ
src/mp_api/client.py 92.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce7c4c...df60edf. Read the comment docs.

@mkhorton mkhorton merged commit d4bce7b into main Feb 18, 2022
@munrojm munrojm deleted the bugfix/pourbaix branch April 18, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants