Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge and spectrum type in xas client #619

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jun 6, 2022

Fixes issues with edge and spectrum_type not getting formatted correctly in the GET request when using the generic search method in the XASRester.

@munrojm munrojm added the release:patch Patch release label Jun 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #619 (05b8d2c) into main (250f51c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   91.68%   91.69%   +0.01%     
==========================================
  Files          35       35              
  Lines        1479     1481       +2     
==========================================
+ Hits         1356     1358       +2     
  Misses        123      123              
Impacted Files Coverage Δ
src/mp_api/routes/xas.py 93.54% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250f51c...05b8d2c. Read the comment docs.

@munrojm munrojm merged commit 3ea2f4b into main Jun 6, 2022
@munrojm munrojm deleted the bugfix/xas_client branch June 6, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants