get_ion_reference_data_for_chemsys: fix bug in str chemsys #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPRester.get_ion_reference_data_for_chemsys()
does not always correctly return data when a chemsys is supplied as astr
. The problem occurs because some element symbols are a subset of others, e.g.B
is a subset ofBi
. The code for this method currently tests whether any of the major elements associated with an ion are inchemsys
:Which causes problems because "B" is
in
"Bi`. For example:Passing the elements as a list is OK
This PR should fix the problem by convert
str
chemsys
intolist
always