You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Pymatgen, the MPStaticSet has a reciprocal_density of 100, as shown here. This overrides the default value of 64 in the MPRelaxSet.yaml. However, in atomate2, the MPGGAStaticSetGenerator does not seem to change the default of 64 to 100.
I'm not sure if I'm missing this somewhere, but that's a potential incompatibility. One would have to dig through atomate1 to be 100% certain (or compare against structures on MP). Note: This bug report was pulled from a larger comment in #724 since I felt it was important to distinguish it.
Andrew-S-Rosen
changed the title
BUG: Potential incompatibility with "old" MP GGA workflow
BUG: Potential incompatibility with "old" MP GGA workflow w.r.t. k-points in GGA static calculations
May 12, 2024
Thanks for pointing this out. We in our group mostly adapt the sets for our runs and therefore don't notice such problems. Especially for future MP production runs, however, this might be highly important.
Thanks for pointing this out! While we'll eventually use KSPACING in lieu of KPOINTS for MP production runs, this has to be fixed for legacy MP workflows. I'm currently working on getting the sets ported to PMG and should probably put the draft PR for that up soon
In Pymatgen, the MPStaticSet has a reciprocal_density of 100, as shown here. This overrides the default value of 64 in the MPRelaxSet.yaml. However, in atomate2, the MPGGAStaticSetGenerator does not seem to change the default of 64 to 100.
I'm not sure if I'm missing this somewhere, but that's a potential incompatibility. One would have to dig through atomate1 to be 100% certain (or compare against structures on MP). Note: This bug report was pulled from a larger comment in #724 since I felt it was important to distinguish it.
Tagging @esoteric-ephemera.
The text was updated successfully, but these errors were encountered: