Transition to pymatgen VASP input sets #854

esoteric-ephemera · 2024-05-16T21:06:00Z

Summary

This PR moves all VASP input sets to the pymatgen input sets, and is dependent on pymatgen PR #3835 - now merged and released in pymatgen==2024.5.31. Merging this PR would close issues #844 and #724 (@Andrew-S-Rosen).

This large change could have breaking consequences outside the VASP library. I've checked that the VASP and LOBSTER code bases are still working as intended, so no breaking changes are expected there. That we've already had incompatibilities between the pymatgen and atomate2 implementations of the same input sets really motivates why this change is needed.

Class duplication has been reduced significantly between pymatgen and atomate2. atomate2.vasp.sets.base.VaspInputSet has been removed, with any features that were not included in its pymatgen counterpart (pymatgen.io.vasp.sets.VaspInputSet) moved to atomate2's VaspInputGenerator.

VaspInputGenerator now inherits from pymatgen's DictSet class. Some features formerly in VaspInputGenerator are included in DictSet per that PR. I've kept VaspInputGenerator after some discussions with @utf and @janosh. This class still adds two methods not included in DictSet, and which are not necessarily useful to include there. The config_dict of inherited classes are now set by their pymatgen equivalents when appropriate (e.g., MPRelaxSet for the MP GGA workflow). Some other changes to the file handling were needed because of this change.

~~I need to update doc strings, but I wanted to wait on more cosmetic changes until we have consensus on code structure.~~

Other changes:

Removed POTCARs and replaced them with spec files where appropriate.
Removed unused vaspout.h5 files, which also contain the full POTCAR (see this pymatgen PR for more context)
Updated pymatgen>=2024.6.4 (thanks @janosh!) and ase>=3.23.0 (many many thanks @Andrew-S-Rosen!)

Request for comments / feedback:

This PR is pretty much complete, but could use some input from various stakeholders:

Lobster (@naik-aakash and @JaGeo): Do you foresee any breaking changes here?
MatPES set (@janosh and @shyuep): The MatPES magmoms were missing from the atomate2 set previously, but are present in their pymatgen set. ~~For now, the atomate2 MatPES set removes the magmoms for consistency with previous versions, but that may have been a bug~~ This PR now corectly sets the magmoms for MatPES.
Structure (@utf, @JaGeo, @janosh): I can completely eliminate VaspInputGenerator by moving its features to RelaxSetGenerator. Right now, RelaxSetGenerator effectively aliases VaspInputGenerator. Any thoughts?

JaGeo · 2024-05-16T21:15:20Z

@esoteric-ephemera thanks. I am currently not sure at all as I cannot forsee the sideeffects of the changes.

shyuep · 2024-05-16T21:21:09Z

I can foresee that the longer this is not done, the more side effects there will be. I have said it before - it is pointless to do coding in a different code base when it is something that is supposed to be another code base. Moving stuff later always creates more problems.

JaGeo · 2024-05-16T21:23:38Z

@shyuep i am not opposing this. I just need to check if there might be something 😅.

@esoteric-ephemera I guess we got our answer. lobster tests are breaking. 😬

esoteric-ephemera · 2024-05-16T21:30:06Z

@esoteric-ephemera I guess we got our answer. lobster tests are breaking. 😬

Yeah I need to dig into this a bit - some of the tests here will fail because of the simultaneous update in pymatgen, but I need to see if that's why first

janosh · 2024-05-16T21:27:30Z

src/atomate2/vasp/sets/base.py

+    def from_directory(directory: str | Path, optional_files: dict = None) -> VaspInput:
        """Load a set of VASP inputs from a directory.

        Note that only the standard INCAR, POSCAR, POTCAR and KPOINTS files are read


any reason to leave from_directory and _get_nedos here? could both be moved to pymatgen as well, which would allow us to remove the VaspInputGenerator class from atomate2 entirely.

Agreed this should be added to pymatgen.

Moved to PMG

janosh · 2024-05-16T21:30:05Z

src/atomate2/vasp/sets/core.py

-        outcar: Outcar = None,
-    ) -> dict:
+    @property
+    def kpoints_updates(self) -> dict | Kpoints:


why dict | Kpoints and not just dict? if it's for parent class compat, prob the parent class needs to change

Being able to return a Kpoints object directly is a nice feature! I think this might be in the pymatgen sets but worth checking.

i strongly recommend homogeneous return type. just asking for trouble calling a Kpoints method on kpoints_updates that fails because it's a dict.
i'd advise to always return either dict or Kpoint. given incar_updates is dict, would minimize user surprise to return dict here as well

Just noting that this is used in some places in pymatgen already:

https://github.com/materialsproject/pymatgen/blob/442d740eb7794d360cb35f187e271b3debb7f047/pymatgen/io/vasp/sets.py#L2159

https://github.com/materialsproject/pymatgen/blob/442d740eb7794d360cb35f187e271b3debb7f047/pymatgen/io/vasp/sets.py#L2218

I think having flexibility can be useful. That said, it wouldn't be much work to allow specifying a kpoints file within a dictionary format, but it does seem like extra boilerplate.

given incar_updates is dict, would minimize user surprise to return dict here as well

Incar is already a dict so you could conceivably return Incar too.

janosh · 2024-05-16T21:33:19Z

src/atomate2/vasp/sets/matpes.py

+_matpes_config_no_magmom["INCAR"].pop("MAGMOM")



MatPES set (@janosh and @shyuep): The MatPES magmoms were missing from the atomate2 set previously, but are present in their pymatgen set. For now, the atomate2 MatPES set removes the magmoms for consistency with previous versions, but that may have been a bug

that sounds like a bug! thanks for catching this! let's remove the .pop("MAGMOM")

janosh · 2024-05-16T21:57:57Z

src/atomate2/vasp/files.py

@@ -192,7 +192,7 @@ def write_vasp_input_set(
    )

    if apply_incar_updates:
-        vis.incar.update(SETTINGS.VASP_INCAR_UPDATES)
+        vis["INCAR"].update(SETTINGS.VASP_INCAR_UPDATES)


might make sense to add

@property def incar(self) -> Incar: """INCAR object.""" return self["INCAR"]

and co for POTCAR, POSCAR, ... to pymatgen DictSet so we can keep vis.incar here

Done on the pmg side

janosh · 2024-05-16T22:37:49Z

Yeah I need to dig into this a bit - some of the tests here will fail because of the simultaneous update in pymatgen, but I need to see if that's why first

@esoteric-ephemera you could temp modify this step to install your pmg PR to test against it until both are ready to go

atomate2/.github/workflows/testing.yml

Lines 70 to 72 in aee4be8

    
                 - name: Install pymatgen from master if triggered by pymatgen repo dispatch 
        
                   if: github.event_name == 'repository_dispatch' && github.event.action == 'pymatgen-ci-trigger' 
        
                   run: pip install --upgrade 'git+https://github.com/materialsproject/pymatgen@${{ github.event.client_payload.pymatgen_ref }}'

      - name: Install pymatgen from master if triggered by pymatgen repo dispatch
-       if: github.event_name == 'repository_dispatch' && github.event.action == 'pymatgen-ci-trigger'
-       run: pip install --upgrade 'git+https://github.com/materialsproject/pymatgen@${{ github.event.client_payload.pymatgen_ref }}'
+       run: pip install --upgrade 'git+https://github.com/materialsproject/pymatgen@refs/pull/854/head'

esoteric-ephemera · 2024-05-17T18:22:56Z

Only the lobster flows (and not the jobs) seemed to be impacted by this change - these just needed a small modification to work correctly

JaGeo · 2024-05-19T07:41:04Z

@esoteric-ephemera we are happy to look at it once the tests are passing.

Why had the Lobster test file to be removed? Thanks in advance.

esoteric-ephemera · 2024-05-20T15:42:02Z

Why had the Lobster test file to be removed? Thanks in advance.

I don't see a lobster test file removed; the vasp.test_base file was renamed vasp.test_run because there's no longer tests of the base classes in it. The remaining test in that file is for atomate2.vasp.run

JaGeo · 2024-05-20T16:27:58Z

@esoteric-ephemera I am referring to your last commit.

Is it ready for us to take a look? Are the tests passing?

esoteric-ephemera · 2024-05-20T18:03:10Z

Ok I see - not all of the lobster tests are run in a temporary directory, so if a test fails, there might be intermediate files written to disk. That happened and the remove lobster test file commit was really removing an intermediate file

Let me know if I should change that behavior for the tests

The tests are passing on my side - I can't get pmg to build from git in the CI nor locally (some issues with c dependencies) but I'll look at that today

JaGeo · 2024-05-20T18:09:14Z

Ok I see - not all of the lobster tests are run in a temporary directory, so if a test fails, there might be intermediate files written to disk. That happened and the remove lobster test file commit was really removing an intermediate file

Let me know if I should change that behavior for the tests

The tests are passing on my side - I can't get pmg to build from git in the CI nor locally (some issues with c dependencies) but I'll look at that today

Ah, I see! Thanks! We might want to modify the Lobster tests in a separate PR then. This will otherwise again lead to many changes not directly related to this PR. Thanks!

I will test the workflows with the latest pymatgen PR tonight.

JaGeo · 2024-05-21T05:47:04Z

@esoteric-ephemera I currently get very weird errors when using these versions of atomate2 and pymatgen to run the Lobster workflow. ("free(): invalid pointer").

@naik-aakash do you maybe have a chance to shortly install both this branch of atomate2 and the linked pymatgen branch and check the Lobster workflow? It might be something else off with my settings...

esoteric-ephemera · 2024-05-21T15:45:17Z

@JaGeo which python did you build your env with? I'm using 3.11, but the cython libraries were reorganized between 3.10 and 3.11, that might lead to the C issues you're seeing (same reason the CI can't build an env for 3.11: as it recompiles the C libraries for python, and pymatgen explicitly includes modules like longintrepr.h which were moved, the build fails)

JaGeo · 2024-05-21T15:47:47Z

@esoteric-ephemera 3.10, I think. Currently on a train (at least not stuck anymore) and cannot definitely confirm

esoteric-ephemera · 2024-05-21T16:40:27Z

No worries @JaGeo. I rebuilt my python env with 3.10 and the tests in tests/vasp/lobster still pass for me. No rush on this

DanielYang59 · 2024-07-21T03:06:24Z

Thanks for pinging me for diagnosing @janosh. I believe materialsvirtuallab/monty#699 would fix this issue @esoteric-ephemera, please let me know if you have further comments, thanks!

With:

@deprecated(replacement=MatPESStaticSet, deadline=(2025, 1, 1))
@dataclass
class MatPesGGAStaticSetGenerator(MatPESStaticSet):
    """Class to generate MP-compatible VASP GGA static input sets."""

    xc_functional: Literal["R2SCAN", "PBE", "PBE+U"] = "PBE"
    auto_ismear: bool = False
    auto_kspacing: bool = False

We now have:

from atomate2.vasp.sets.matpes import MatPesGGAStaticSetGenerator

generator = MatPesGGAStaticSetGenerator()

assert generator.xc_functional == "PBE"
assert not generator.auto_ismear
print(generator.as_dict())

Output:

{'@module': 'atomate2.vasp.sets.matpes', '@class': 'MatPesGGAStaticSetGenerator', '@version': '0.0.14.post173+g56d77311', 'structure': None, 'config_dict': {'PARENT': 'PBE64Base', 'INCAR': {'ALGO': 'Normal', 'EDIFF': 1e-05, 'ENAUG': 1360, 'ENCUT': 680, 'GGA': 'PE', 'ISMEAR': 0, 'ISPIN': 2, 'KSPACING': 0.22, 'LAECHG': True, 'LASPH': True, 'LCHARG': True, 'LMIXTAU': True, 'LORBIT': 11, 'LREAL': False, 'LWAVE': False, 'NELM': 200, 'NSW': 0, 'PREC': 'Accurate', 'SIGMA': 0.05, 'LDAU': False, 'LMAXMIX': 6, 'LDAUJ': {'F': {'Co': 0, 'Cr': 0, 'Fe': 0, 'Mn': 0, 'Mo': 0, 'Ni': 0, 'V': 0, 'W': 0}, 'O': {'Co': 0, 'Cr': 0, 'Fe': 0, 'Mn': 0, 'Mo': 0, 'Ni': 0, 'V': 0, 'W': 0}}, 'LDAUL': {'F': {'Co': 2, 'Cr': 2, 'Fe': 2, 'Mn': 2, 'Mo': 2, 'Ni': 2, 'V': 2, 'W': 2}, 'O': {'Co': 2, 'Cr': 2, 'Fe': 2, 'Mn': 2, 'Mo': 2, 'Ni': 2, 'V': 2, 'W': 2}}, 'LDAUTYPE': 2, 'LDAUU': {'F': {'Co': 3.32, 'Cr': 3.7, 'Fe': 5.3, 'Mn': 3.9, 'Mo': 4.38, 'Ni': 6.2, 'V': 3.25, 'W': 6.2}, 'O': {'Co': 3.32, 'Cr': 3.7, 'Fe': 5.3, 'Mn': 3.9, 'Mo': 4.38, 'Ni': 6.2, 'V': 3.25, 'W': 6.2}}, 'MAGMOM': {'Ce': 5, 'Ce3+': 1, 'Co': 0.6, 'Co3+': 0.6, 'Co4+': 1, 'Cr': 5, 'Dy3+': 5, 'Er3+': 3, 'Eu': 10, 'Eu2+': 7, 'Eu3+': 6, 'Fe': 5, 'Gd3+': 7, 'Ho3+': 4, 'La3+': 0.6, 'Lu3+': 0.6, 'Mn': 5, 'Mn3+': 4, 'Mn4+': 3, 'Mo': 5, 'Nd3+': 3, 'Ni': 5, 'Pm3+': 4, 'Pr3+': 2, 'Sm3+': 5, 'Tb3+': 6, 'Tm3+': 2, 'V': 5, 'W': 5, 'Yb3+': 1}}, 'POTCAR_FUNCTIONAL': 'PBE_64', 'POTCAR': {'Ac': 'Ac', 'Ag': 'Ag', 'Al': 'Al', 'Am': 'Am', 'Ar': 'Ar', 'As': 'As', 'At': 'At', 'Au': 'Au', 'B': 'B', 'Ba': 'Ba_sv', 'Be': 'Be_sv', 'Bi': 'Bi', 'Br': 'Br', 'C': 'C', 'Ca': 'Ca_sv', 'Cd': 'Cd', 'Ce': 'Ce', 'Cf': 'Cf', 'Cl': 'Cl', 'Cm': 'Cm', 'Co': 'Co', 'Cr': 'Cr_pv', 'Cs': 'Cs_sv', 'Cu': 'Cu_pv', 'Dy': 'Dy_3', 'Er': 'Er_3', 'Eu': 'Eu', 'F': 'F', 'Fe': 'Fe_pv', 'Fr': 'Fr_sv', 'Ga': 'Ga_d', 'Gd': 'Gd', 'Ge': 'Ge_d', 'H': 'H', 'He': 'He', 'Hf': 'Hf_pv', 'Hg': 'Hg', 'Ho': 'Ho_3', 'I': 'I', 'In': 'In_d', 'Ir': 'Ir', 'K': 'K_sv', 'Kr': 'Kr', 'La': 'La', 'Li': 'Li_sv', 'Lu': 'Lu_3', 'Mg': 'Mg_pv', 'Mn': 'Mn_pv', 'Mo': 'Mo_pv', 'N': 'N', 'Na': 'Na_pv', 'Nb': 'Nb_pv', 'Nd': 'Nd_3', 'Ne': 'Ne', 'Ni': 'Ni_pv', 'Np': 'Np', 'O': 'O', 'Os': 'Os_pv', 'P': 'P', 'Pa': 'Pa', 'Pb': 'Pb_d', 'Pd': 'Pd', 'Pm': 'Pm_3', 'Po': 'Po_d', 'Pr': 'Pr_3', 'Pt': 'Pt', 'Pu': 'Pu', 'Ra': 'Ra_sv', 'Rb': 'Rb_sv', 'Re': 'Re_pv', 'Rh': 'Rh_pv', 'Rn': 'Rn', 'Ru': 'Ru_pv', 'S': 'S', 'Sb': 'Sb', 'Sc': 'Sc_sv', 'Se': 'Se', 'Si': 'Si', 'Sm': 'Sm_3', 'Sn': 'Sn_d', 'Sr': 'Sr_sv', 'Ta': 'Ta_pv', 'Tb': 'Tb_3', 'Tc': 'Tc_pv', 'Te': 'Te', 'Th': 'Th', 'Ti': 'Ti_pv', 'Tl': 'Tl_d', 'Tm': 'Tm_3', 'U': 'U', 'V': 'V_pv', 'W': 'W_sv', 'Xe': 'Xe', 'Y': 'Y_sv', 'Yb': 'Yb_3', 'Zn': 'Zn', 'Zr': 'Zr_sv'}}, 'files_to_transfer': {}, 'user_incar_settings': {}, 'user_kpoints_settings': {}, 'user_potcar_settings': {}, 'constrain_total_magmom': False, 'sort_structure': True, 'user_potcar_functional': 'PBE_64', 'force_gamma': False, 'reduce_structure': None, 'vdw': None, 'use_structure_charge': False, 'standardize': False, 'sym_prec': 0.1, 'international_monoclinic': True, 'validate_magmom': True, 'inherit_incar': ['LPEAD', 'NGX', 'NGY', 'NGZ', 'SYMPREC', 'IMIX', 'LMAXMIX', 'KGAMMA', 'ISYM', 'NCORE', 'NPAR', 'NELMIN', 'IOPT', 'NBANDS', 'KPAR', 'AMIN', 'NELMDL', 'BMIX', 'AMIX_MAG', 'BMIX_MAG'], 'auto_kspacing': False, 'auto_ismear': False, 'auto_ispin': False, 'auto_lreal': False, 'auto_metal_kpoints': False, 'bandgap_tol': 0.0001, 'bandgap': None, 'prev_incar': None, 'prev_kpoints': None, '_valid_potcars': None, 'xc_functional': 'PBE'}

esoteric-ephemera · 2024-07-22T15:42:05Z

Thanks @DanielYang59! That looks more like what I expect to see from the as_dict()

codecov · 2024-07-22T16:01:44Z

Codecov Report

Attention: Patch coverage is 88.77005% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.13%. Comparing base (29a5731) to head (bd98d1b).
Report is 67 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   74.94%   75.13%   +0.19%     
==========================================
  Files         136      142       +6     
  Lines       10513    10614     +101     
  Branches     1643     1580      -63     
==========================================
+ Hits         7879     7975      +96     
- Misses       2143     2167      +24     
+ Partials      491      472      -19

Files	Coverage Δ
src/atomate2/abinit/sets/base.py	`76.25% <ø> (ø)`
src/atomate2/common/files.py	`80.39% <ø> (ø)`
src/atomate2/common/jobs/defect.py	`81.81% <ø> (+0.13%)`	⬆️
src/atomate2/cp2k/jobs/base.py	`89.23% <ø> (ø)`
src/atomate2/vasp/files.py	`85.96% <100.00%> (ø)`
src/atomate2/vasp/flows/defect.py	`83.58% <100.00%> (ø)`
src/atomate2/vasp/flows/matpes.py	`72.41% <100.00%> (ø)`
src/atomate2/vasp/flows/mp.py	`90.32% <100.00%> (ø)`
src/atomate2/vasp/jobs/lobster.py	`91.93% <100.00%> (+0.26%)`	⬆️
src/atomate2/vasp/jobs/matpes.py	`86.66% <100.00%> (ø)`
... and 8 more

... and 6 files with indirect coverage changes

utf · 2024-07-24T07:34:45Z

src/atomate2/common/files.py

@@ -35,11 +35,11 @@ def copy_files(
        either "usernamehost" or just "host" in which case the username
        will be inferred from the current user. If ``None``, the local filesystem will
        be used as the source.
-    include_files : None or list of (str or .Path)
+    include_files : None | list[str | Path]


Is there a reason you changed the doc strings? I think the correct style is to use "or" in the string since it is human readable. E.g. see here https://numpydoc.readthedocs.io/en/latest/format.html#parameters

I didn't make these changes, they're from here. But I'll revert them

OK reverted!

utf

Hi @esoteric-ephemera just noticed one thing about the doc strings. After that, is this ready to merge or do we need to wait for a new monty release?

esoteric-ephemera · 2024-07-24T17:43:48Z

Hi @esoteric-ephemera just noticed one thing about the doc strings. After that, is this ready to merge or do we need to wait for a new monty release?

Just made the docstr changes. We could wait for monty, right now the deprecation warnings print something like:

<string>:31: FutureWarning: __post_init__ is deprecated, and will be removed on 2025-01-01
Use MPRelaxSet in pymatgen.io.vasp.sets instead.

which isn't very instructive because of the name used. Happy to change it if preferred

utf · 2024-07-25T11:08:14Z

Ok, once a new version of monty is released we can merge this. Thanks very much for your work getting this over the line.

esoteric-ephemera · 2024-07-25T16:03:21Z

Sounds good and thanks!

warning before: <string>:31: FutureWarning: __post_init__ is deprecated, and will be removed on 2025-01-01 Use MPRelaxSet in pymatgen.io.vasp.sets instead. warning after: <string>:31: FutureWarning: MPGGARelaxSetGenerator is deprecated, and will be removed on 2025-01-01 Use MPRelaxSet in pymatgen.io.vasp.sets instead.

janosh · 2024-07-29T18:41:08Z

monty==v2024.7.29 was released 8 hours ago so i'll set this to auto-merge. thanks @esoteric-ephemera for the massive amount of work that went into this PR! 🙏

esoteric-ephemera · 2024-07-29T21:21:31Z

Fantastic @janosh! Added a little fix for the Lobster schemas to work with the newer version of monty, pending your PR getting released

utf · 2024-07-30T13:50:55Z

Thanks @esoteric-ephemera this is fantastic.

esoteric-ephemera added 5 commits May 16, 2024 13:48

complete refactor to PMG input sets for vasp

fe04d57

bug fixes for input set change

d3824fa

linting

2d84c67

move type import to type_checking block

e580080

remove duplicated MP yaml files

e348dfe

esoteric-ephemera changed the title ~~Transition VASP to use pymatgen for input sets~~ Transition VASP to pymatgen input sets May 16, 2024

esoteric-ephemera changed the title ~~Transition VASP to pymatgen input sets~~ Transition to pymatgen VASP input sets May 16, 2024

janosh reviewed May 16, 2024

View reviewed changes

drop dict.get(key, None) -> dict.get(key)

fbb94a4

esoteric-ephemera mentioned this pull request May 17, 2024

Update VASP input sets for atomate2 compatibility materialsproject/pymatgen#3835

Merged

esoteric-ephemera added 5 commits May 17, 2024 10:51

change inheritance slightly, install pmg from pr

14f67fe

linting

9e83245

revert vis["INCAR"] --> vis.incar

23a9cf0

fix lobster interface

9797971

remove lobster test file

a4945e8

DanielYang59 mentioned this pull request Jul 21, 2024

Add missing functools.wraps decorator to deprecated decorator and handle dataclass properly materialsvirtuallab/monty#699

Merged

Merge branch 'main' into pmg

bd98d1b

utf reviewed Jul 24, 2024

View reviewed changes

revert docstr changes

2a1fb54

janosh added 2 commits July 29, 2024 14:39

pin monty==2024.7.30 in deps and strict

c87df9c

janosh enabled auto-merge (squash) July 29, 2024 18:41

janosh mentioned this pull request Jul 29, 2024

Fix zpath when passing pathlib.Path materialsvirtuallab/monty#704

Merged

esoteric-ephemera added 2 commits July 29, 2024 14:15

add kludge for monty zpath

6176d49

precommit

34f937d

auto-merge was automatically disabled July 29, 2024 21:19
Head branch was pushed to by a user without write access

Merge branch 'main' into pmg

14d7a5e

esoteric-ephemera and others added 3 commits July 29, 2024 14:58

extend monty fix to vasp tests

1232090

precommit

fedf257

Merge branch 'main' into pmg

9fb14e9

utf enabled auto-merge (squash) July 30, 2024 13:50

utf merged commit fad9396 into materialsproject:main Jul 30, 2024
6 checks passed

esoteric-ephemera deleted the pmg branch August 1, 2024 19:07

janosh mentioned this pull request Aug 6, 2024

Add back symprec kwarg to MP and MatPES set generators #947

Merged

utf added the feature A new feature being added label Aug 20, 2024

		_matpes_config_no_magmom["INCAR"].pop("MAGMOM")

Transition to pymatgen VASP input sets #854

Transition to pymatgen VASP input sets #854

Conversation

esoteric-ephemera commented May 16, 2024 • edited Loading

Summary

Other changes:

Request for comments / feedback:

JaGeo commented May 16, 2024

shyuep commented May 16, 2024

JaGeo commented May 16, 2024 • edited Loading

esoteric-ephemera commented May 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janosh May 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janosh commented May 16, 2024

esoteric-ephemera commented May 17, 2024 • edited Loading

JaGeo commented May 19, 2024

esoteric-ephemera commented May 20, 2024

JaGeo commented May 20, 2024

esoteric-ephemera commented May 20, 2024 • edited Loading

JaGeo commented May 20, 2024 • edited Loading

JaGeo commented May 21, 2024

esoteric-ephemera commented May 21, 2024 • edited Loading

JaGeo commented May 21, 2024

esoteric-ephemera commented May 21, 2024

DanielYang59 commented Jul 21, 2024 • edited Loading

esoteric-ephemera commented Jul 22, 2024

codecov bot commented Jul 22, 2024

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

utf left a comment

Choose a reason for hiding this comment

esoteric-ephemera commented Jul 24, 2024 • edited Loading

utf commented Jul 25, 2024

esoteric-ephemera commented Jul 25, 2024

janosh commented Jul 29, 2024

esoteric-ephemera commented Jul 29, 2024

utf commented Jul 30, 2024

esoteric-ephemera commented May 16, 2024 •

edited

Loading

JaGeo commented May 16, 2024 •

edited

Loading

janosh May 16, 2024 •

edited

Loading

esoteric-ephemera commented May 17, 2024 •

edited

Loading

esoteric-ephemera commented May 20, 2024 •

edited

Loading

JaGeo commented May 20, 2024 •

edited

Loading

esoteric-ephemera commented May 21, 2024 •

edited

Loading

DanielYang59 commented Jul 21, 2024 •

edited

Loading

esoteric-ephemera commented Jul 24, 2024 •

edited

Loading