Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more documentation for Lobster #267

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

JaGeo
Copy link
Member

@JaGeo JaGeo commented Mar 13, 2023

Summary

I have added a few more lines of documentation for Lobster.

An additional question that is related: Should we also work on tutorials for certain, more complex flows?

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #267 (12df3b9) into main (f44320c) will decrease coverage by 0.21%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   76.90%   76.69%   -0.21%     
==========================================
  Files          62       62              
  Lines        5317     5317              
  Branches      755      755              
==========================================
- Hits         4089     4078      -11     
- Misses       1020     1032      +12     
+ Partials      208      207       -1     

see 2 files with indirect coverage changes

@utf
Copy link
Member

utf commented Mar 13, 2023

Thanks @JaGeo. I was also thinking we could have a separate tutorial for each advanced workflow. I should make one for amset, and it would be great if @jmmshn could think about a defects one at some point too. That will definitely increase usability and hopefully get more people using atomate2.

@utf utf merged commit 41e898c into materialsproject:main Mar 13, 2023
@utf utf added the docs Improvements or additions to documentation label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants