Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing molecule field to cclib TaskDocument #343

Closed
wants to merge 4 commits into from
Closed

Add missing molecule field to cclib TaskDocument #343

wants to merge 4 commits into from

Conversation

Andrew-S-Rosen
Copy link
Member

Closes #342.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #343 (96fa4c7) into main (b4a87a3) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   65.73%   65.57%   -0.16%     
==========================================
  Files          72       72              
  Lines        7018     7018              
  Branches      896      896              
==========================================
- Hits         4613     4602      -11     
- Misses       2138     2150      +12     
+ Partials      267      266       -1     
Impacted Files Coverage Δ
src/atomate2/common/schemas/cclib.py 74.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Andrew-S-Rosen
Copy link
Member Author

@utf this is ready to go.

@Andrew-S-Rosen Andrew-S-Rosen closed this by deleting the head repository May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: cclib TaskDocument is missing molecule field
1 participant