Fix KspacingMetalHandler triggering on runs that don't use KSPACING

[janosh]

@esoteric-ephemera and I noticed that the KspacingMetalHandler (formerly ScanMetalHandler) triggers even for runs that don't use KSPACING due to using a bad fallback value in

v.incar.get("KSPACING", 1) > 0.22

custodian/custodian/vasp/handlers.py

Lines 1185 to 1195 in 6019d60

	v = Vasprun(self.output_filename)
	# check whether bandgap is zero and KSPACING is too large
	# using 0 as fallback value for KSPACING so that this handler does not trigger if KSPACING is not set
	if v.eigenvalue_band_properties[0] == 0 and v.incar.get("KSPACING", 0) > 0.22:
	return True
	except Exception:
	pass
	return False
	def correct(self):
	"""Perform corrections."""

If "KSPACING" is not in v.incar this check will still return True and apply the corresponding KSPACING reduction correction.

@rkingsbury Would be great to get your feedback on this in case we overlooked something.

The reason for renaming to KspacingMetalHandler (ScanMetalHandler is still around but deprecated) is that KSPACING is not specific to SCAN and in fact may in the future be used by the MP GGA workflows as well.

We added a test in 6019d60 to make sure the handler does not trigger on an INCAR that doesn't specify KSPACING.

Pinging @Andrew-S-Rosen, @utf, @JaGeo in case you'd like to chime in.

[codecov-commenter]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (377454c) 65.83% compared to head (5f52a59) 65.92%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   65.83%   65.92%   +0.09%     
==========================================
  Files          51       51              
  Lines        5628     5641      +13     
==========================================
+ Hits         3705     3719      +14     
+ Misses       1923     1922       -1     

Files	Coverage Δ
custodian/vasp/tests/test_handlers.py	99.78% <100.00%> (+<0.01%)	⬆️
custodian/custodian.py	78.75% <80.00%> (ø)
custodian/vasp/handlers.py	78.43% <71.42%> (+0.23%)	⬆️
custodian/vasp/jobs.py	49.72% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.