Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxidation State Document #198

Merged
merged 3 commits into from
May 27, 2021
Merged

Oxidation State Document #198

merged 3 commits into from
May 27, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented May 27, 2021

Adds a new oxidation state document and tests

@codecov-commenter
Copy link

Codecov Report

Merging #198 (4921d69) into main (7bb7485) will decrease coverage by 0.12%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   95.45%   95.33%   -0.13%     
==========================================
  Files          25       26       +1     
  Lines        1737     1778      +41     
==========================================
+ Hits         1658     1695      +37     
- Misses         79       83       +4     
Impacted Files Coverage Δ
emmet-core/emmet/core/oxidation_states.py 90.24% <90.24%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb7485...4921d69. Read the comment docs.

@shyamd shyamd merged commit 9082fc4 into main May 27, 2021
@shyamd shyamd deleted the oxidation_states branch May 28, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants